[ 
https://issues.apache.org/jira/browse/LENS-630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14620150#comment-14620150
 ] 

Rajat Khandelwal edited comment on LENS-630 at 7/9/15 9:09 AM:
---------------------------------------------------------------

Before this change, QueryCost was a concrete class, HiveDriver was always 
returning QueryCost(resourceUsage=1, execTime=1) and JDBCDriver was always 
returning QueryCost(resourceUsage=0,execTime=0). 

Estimate API was returning the same object as the one returned by selected 
driver.

After this change, FactPartitionBasedQueryCost is the implementation of 
QueryCost used across the code. HiveDriver will return 
FactPartitionBasedQueryCost(resourceUsage=weighted cost of partitions queried) 
and JDBCDriver will return FactPartitionBasedQueryCost(resourceUsage=0)

Estimate API will now return QueryCostTO(driverCost.resourceUsage(), null) 
where driverCost is cost returned by selected driver. 



was (Author: prongs):
Before this change, QueryCost was a concrete class, HiveDriver was always 
returning QueryCost(resourceUsage=1, execTime=1) and JDBCDriver was always 
returning QueryCost(resourceUsage=0,execTime=0). 
After this change, HiveDriver will return QueryCostTO(resourceUsage=weighted 
cost of partitions queried, execTime=null) and JDBCDriver will return 
QueryCostTO(resourceUsage=0, execTime=null)



> Using Duration and Fact Weight Based Query Cost Calculator for Hive Driver
> --------------------------------------------------------------------------
>
>                 Key: LENS-630
>                 URL: https://issues.apache.org/jira/browse/LENS-630
>             Project: Apache Lens
>          Issue Type: Improvement
>          Components: api, driver-hive, driver-jdbc, server
>            Reporter: Himanshu Gahlaut
>            Assignee: Rajat Khandelwal
>              Labels: incompatible
>             Fix For: 2.3
>
>         Attachments: LENS-630_12.patch
>
>
> Along with this, we can add a new field in QueryCost to return the query cost 
> calculated by the implementation. normalizedQueryCost could be one name for 
> that field.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to