----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36350/#review91271 -----------------------------------------------------------
Ship it! lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java (line 836) <https://reviews.apache.org/r/36350/#comment144564> Instead of creating anonymous sub class of ArrayList, we can use `Lists.newArrayList(E... elements)`. - Rajat Khandelwal On July 10, 2015, 9:42 a.m., Amareshwari Sriramadasu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36350/ > ----------------------------------------------------------- > > (Updated July 10, 2015, 9:42 a.m.) > > > Review request for lens and Rajat Khandelwal. > > > Bugs: LENS-648 > https://issues.apache.org/jira/browse/LENS-648 > > > Repository: lens > > > Description > ------- > > Fixes NPE. > Added regression test which fails without patch > > > Diffs > ----- > > > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java > 1b5c09a > lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java > 432c5f4 > > lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java > 8c3c219 > lens-cube/src/test/resources/log4j.properties a87fd8f > > Diff: https://reviews.apache.org/r/36350/diff/ > > > Testing > ------- > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.958s] > [INFO] Lens .............................................. SUCCESS [2.830s] > [INFO] Lens API .......................................... SUCCESS [19.672s] > [INFO] Lens API for server and extensions ................ SUCCESS [17.526s] > [INFO] Lens Cube ......................................... SUCCESS [4:13.366s] > [INFO] Lens DB storage ................................... SUCCESS [18.716s] > [INFO] Lens Query Library ................................ SUCCESS [14.748s] > [INFO] Lens Hive Driver .................................. SUCCESS [2:45.173s] > [INFO] Lens Driver for JDBC .............................. SUCCESS [35.707s] > [INFO] Lens Server ....................................... SUCCESS [5:32.198s] > [INFO] Lens client ....................................... SUCCESS [33.653s] > [INFO] Lens CLI .......................................... SUCCESS [2:37.161s] > [INFO] Lens Examples ..................................... SUCCESS [9.670s] > [INFO] Lens Distribution ................................. SUCCESS [8.240s] > [INFO] Lens ML Lib ....................................... SUCCESS [1:21.271s] > [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.776s] > [INFO] Lens Regression ................................... SUCCESS [9.410s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 19:23.926s > [INFO] Finished at: Thu Jul 09 13:10:34 UTC 2015 > [INFO] Final Memory: 171M/1290M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Amareshwari Sriramadasu > >
