> On July 13, 2015, 1:32 p.m., Rajat Khandelwal wrote:
> > lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java,
> >  line 1234
> > <https://reviews.apache.org/r/36444/diff/1/?file=1009241#file1009241line1234>
> >
> >     I don't think we need to remove any test case.

No test case was removed. The added feature eliminates need for using LensQuery 
to fetch query status (by calling result.getStatus()).


On July 13, 2015, 1:32 p.m., Tushar Ghosh wrote:
> > Can you post result of `mvn clean install` in the `testing done` section?

I have shared the output of mvn clean install in the testing done section.


- Tushar


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36444/#review91440
-----------------------------------------------------------


On July 13, 2015, 1:20 p.m., Tushar Ghosh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36444/
> -----------------------------------------------------------
> 
> (Updated July 13, 2015, 1:20 p.m.)
> 
> 
> Review request for lens and Amareshwari Sriramadasu.
> 
> 
> Bugs: LENS-387
>     https://issues.apache.org/jira/browse/LENS-387
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Added member in org.apache.lens.api.QueryHandleWithResultSet.java for storing 
> query status.
> 
> 
> Diffs
> -----
> 
>   
> lens-api/src/main/java/org/apache/lens/api/query/QueryHandleWithResultSet.java
>  4fd5081 
>   
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java
>  8a32202 
>   
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 
> 76d3dee 
> 
> Diff: https://reviews.apache.org/r/36444/diff/
> 
> 
> Testing
> -------
> 
> Project Build successful with modifications.
> 
> 
> Thanks,
> 
> Tushar Ghosh
> 
>

Reply via email to