> On July 13, 2015, 2:59 p.m., Amareshwari Sriramadasu wrote: > > lens-server/src/main/java/org/apache/lens/server/rewrite/UserQueryToCubeQueryRewriter.java, > > line 41 > > <https://reviews.apache.org/r/36257/diff/3/?file=1009257#file1009257line41> > > > > What happens if conf LensConfConstants.QUERY_PHASE1_REWRITERS is not > > set? Is it already taken care in getClasses? or does it throw NPE ?
I think current test cases are covering this. The variable is not set and no failures. - Rajat ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36257/#review91448 ----------------------------------------------------------- On July 13, 2015, 1:37 p.m., Rajat Khandelwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36257/ > ----------------------------------------------------------- > > (Updated July 13, 2015, 1:37 p.m.) > > > Review request for lens. > > > Bugs: LENS-24 > https://issues.apache.org/jira/browse/LENS-24 > > > Repository: lens > > > Description > ------- > > user query to cube query rewriter, and test cases > > > Diffs > ----- > > lens-cube/src/main/java/org/apache/lens/driver/cube/RewriteUtil.java > 5ecee1985b0c36d52b8fc52ccda82e37ad277724 > lens-cube/src/test/java/org/apache/lens/driver/cube/TestRewriting.java > 2dac223abdbddce74706f663d13115ce7a178b1a > > lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java > 0e0beb823a85dc392c54582d6ec7292bb7322be6 > lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java > 0f2b7401b4057b3a93aa5a13066972bc1975142e > > lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java > ad27d78e1839fa60df8f2429901b77221be71653 > > lens-server-api/src/main/java/org/apache/lens/server/api/error/LensException.java > 49b118d221adb09fdfa1bbb2bc5940813ac9443d > > lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java > 0cccaef5abf391179b04bca0c0bbe799429f9065 > > lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryRewriter.java > 355a4e9b3bbf95b0da34bd854c85a5534eb641e2 > > lens-server-api/src/main/java/org/apache/lens/server/api/query/rewrite/Phase1Rewriter.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/query/rewrite/Phase2Rewriter.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/query/rewrite/QueryRewriter.java > PRE-CREATION > lens-server-api/src/main/java/org/apache/lens/server/rewrite/Rewriter.java > PRE-CREATION > lens-server/pom.xml b85292cb21e6cd4681a1f6b2b7ee1367cd2dc60a > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java > 8a322027905edef9403c45fb13cb985e7e4a2f59 > lens-server/src/main/java/org/apache/lens/server/rewrite/RewriteUtil.java > PRE-CREATION > > lens-server/src/main/java/org/apache/lens/server/rewrite/UserQueryToCubeQueryRewriter.java > PRE-CREATION > lens-server/src/test/java/org/apache/lens/server/rewrite/TestRewriting.java > PRE-CREATION > > lens-server/src/test/java/org/apache/lens/server/rewrite/TestUserQueryToCubeQueryRewriter.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/36257/diff/ > > > Testing > ------- > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.455s] > [INFO] Lens .............................................. SUCCESS [3.409s] > [INFO] Lens API .......................................... SUCCESS [21.909s] > [INFO] Lens API for server and extensions ................ SUCCESS [20.058s] > [INFO] Lens Cube ......................................... SUCCESS [3:56.765s] > [INFO] Lens DB storage ................................... SUCCESS [21.392s] > [INFO] Lens Query Library ................................ SUCCESS [18.184s] > [INFO] Lens Hive Driver .................................. SUCCESS [2:49.329s] > [INFO] Lens Driver for JDBC .............................. SUCCESS [34.714s] > [INFO] Lens Server ....................................... SUCCESS [5:27.883s] > [INFO] Lens client ....................................... SUCCESS [34.498s] > [INFO] Lens CLI .......................................... SUCCESS [2:35.410s] > [INFO] Lens Examples ..................................... SUCCESS [8.460s] > [INFO] Lens Distribution ................................. SUCCESS [8.288s] > [INFO] Lens ML Lib ....................................... SUCCESS [1:19.170s] > [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.674s] > [INFO] Lens Regression ................................... SUCCESS [10.862s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 19:15.379s > [INFO] Finished at: Wed Jul 08 13:03:57 UTC 2015 > [INFO] Final Memory: 191M/2202M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Rajat Khandelwal > >
