----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36349/#review91598 -----------------------------------------------------------
lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java (line 230) <https://reviews.apache.org/r/36349/#comment145073> Update partition instead of Adds ? lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java (lines 175 - 182) <https://reviews.apache.org/r/36349/#comment145076> We do add and drop partitions through Storage class - which updates information wrt latest parts if the partition is latest. Why are we not going through storage class here? -the update might skipped for latest parts. lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java (line 811) <https://reviews.apache.org/r/36349/#comment145078> We should use storagePartSpecFromXPartition instead of adding new. This method may not be using the same reading contract from xsd. lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java (line 1099) <https://reviews.apache.org/r/36349/#comment145079> Please update javadoc wrt new param. Same applies to all changes in the file. - Amareshwari Sriramadasu On July 9, 2015, 12:25 p.m., Rajat Khandelwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36349/ > ----------------------------------------------------------- > > (Updated July 9, 2015, 12:25 p.m.) > > > Review request for lens. > > > Bugs: LENS-652 > https://issues.apache.org/jira/browse/LENS-652 > > > Repository: lens > > > Description > ------- > > Our Requirement is to be able to change path of an existing partition. > > > Diffs > ----- > > > lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionTableCommands.java > 6a9339365b7980d1db7f9c0f5bb8c414956611f8 > lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java > bdb9c382fc0badfa19604aeeb329953b8919dc0b > > lens-cli/src/main/java/org/apache/lens/cli/commands/PhysicalTableCrudCommand.java > a479c14d37f39b0a5fd95801a5d6b69e3f2037ff > lens-client/src/main/java/org/apache/lens/client/LensClient.java > b15b024369b8b8b1229f8923f0c809936f10577f > lens-client/src/main/java/org/apache/lens/client/LensMetadataClient.java > b4e05524debaa747674014607a6047b9c3b3b63b > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java > dc2d9f64e5c9ea2588e5a58814a82d75854bfdd7 > > lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java > 18b6c876abdf925b1c718b606377b72f90c4466b > > lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java > 6226521545fc1dc478c41595c58a97e2f800f47a > > lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java > c5e1c14377b9ffe54e69a841559ab73df61ca162 > lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java > 811fd329141bb6f192c11df0bbde8fd4a89bbd3c > > lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java > bfe4813b78ac98d45e0635d69c40ab6c5ae30fa0 > > Diff: https://reviews.apache.org/r/36349/diff/ > > > Testing > ------- > > > Thanks, > > Rajat Khandelwal > >
