> On July 16, 2015, 11:30 a.m., Amareshwari Sriramadasu wrote: > > lens-server-api/src/main/java/org/apache/lens/server/model/MappedDiagnosticLogSegregationContext.java, > > lines 40-41 > > <https://reviews.apache.org/r/36543/diff/1/?file=1013262#file1013262line40> > > > > Setting LOG_SEGREGATION_ID from setQueryId, as all the callers will set > > it as LOG_SEGREGATION_ID as well.
We can rename methods in LogSegrationContext interface to align more with what they do internally: setLogSegragationId(String id): only sets log segragation id setQueryId(String id): only sets query id setLogSegragationAndQueryId(String id): internally calls both setLogSegrationId and setQueryId - Himanshu ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36543/#review91879 ----------------------------------------------------------- On July 16, 2015, 11:10 a.m., Amareshwari Sriramadasu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36543/ > ----------------------------------------------------------- > > (Updated July 16, 2015, 11:10 a.m.) > > > Review request for lens and Himanshu Gahlaut. > > > Bugs: LENS-669 > https://issues.apache.org/jira/browse/LENS-669 > > > Repository: lens > > > Description > ------- > > Initial patch for review. > > > Diffs > ----- > > lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java > e048a78 > > lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java > 1334d9a > > lens-server-api/src/main/java/org/apache/lens/server/model/LogSegregationContext.java > 8691a05 > > lens-server-api/src/main/java/org/apache/lens/server/model/MappedDiagnosticLogSegregationContext.java > 989cb9d > > lens-server/src/main/java/org/apache/lens/server/query/QueryEndNotifier.java > df36a21 > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java > 3511236 > lens-server/src/main/java/org/apache/lens/server/query/ResultFormatter.java > c526c02 > > Diff: https://reviews.apache.org/r/36543/diff/ > > > Testing > ------- > > Pending. > > > Thanks, > > Amareshwari Sriramadasu > >
