-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36393/
-----------------------------------------------------------

(Updated July 17, 2015, 11:07 a.m.)


Review request for lens.


Changes
-------

Addressed review comments. Testing not done.


Summary (updated)
-----------------

LENS-619: Applying Query Launching constraints before launching a new query


Bugs: LENS-619
    https://issues.apache.org/jira/browse/LENS-619


Repository: lens


Description (updated)
-------

LENS-619: Applying Query Launching constraints before launching a new query


Diffs (updated)
-----

  lens-api/src/main/java/org/apache/lens/api/Addable.java 
5a556918afcdb8967deee84472cd7863aeafc4fc 
  lens-api/src/main/java/org/apache/lens/api/query/LensQuery.java 
f594133e8a75603e5bb0c913d62ea189248cfa05 
  lens-api/src/main/java/org/apache/lens/api/query/QueryStatus.java 
539f0b0b0804257fae6b7ec0af8f2f715175d597 
  lens-client/src/main/java/org/apache/lens/client/LensStatement.java 
f7305fb288167cda088e263a62c77f264d779127 
  lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 
e87ed23429d3172db86c17e4ec5e37e2e903374b 
  lens-driver-hive/src/main/resources/hivedriver-default.xml 
85a3f89deba44a9ca5ef4ffd41074b1405d846b6 
  lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java 
e048a78a08b29045f86e69f0180ab04f50705315 
  
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriverConfConstants.java
 5abd040c46cc6a3b81c89ef9ccdfc70dc09c2fae 
  lens-driver-jdbc/src/main/resources/jdbcdriver-default.xml 
99f6f205dfe6f1c16277ac6624106436df2b2b8f 
  lens-server-api/pom.xml b0b0fe017a239b24c3b9606b3be77a1722844e0f 
  
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 
eab42d095ced23b9fd5b1fb854043d9668307883 
  
lens-server-api/src/main/java/org/apache/lens/server/api/common/ConfigBasedObjectCreationFactory.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverSelector.java
 dea0dfb50657b60fc71a9cb263266dec1dfbdf68 
  
lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java 
b56c67ce6909a11b1cdec9f52427683f0b11dd41 
  
lens-server-api/src/main/java/org/apache/lens/server/api/driver/MinQueryCostSelector.java
 c3fe8eb142569c0b254f551c3cbd18502b6eac99 
  
lens-server-api/src/main/java/org/apache/lens/server/api/metrics/MetricsService.java
 71128b7d35e91fadf38a9c3926ce46d42369ead4 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java
 1334d9a96d90f17788367b123451d9c3dcb70824 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/DriverSelectorQueryContext.java
 3e7de173a4e3083ca3ac5fa95fd7cd09e7f028bb 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/FinishedLensQuery.java
 6e7ab5dc1c78407a24e389c001ca3100563e3795 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java
 d72727e7832d02ed2ea90379cd29c7a8e509a8f8 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryExecutionService.java
 5d7163f112d7c7115ebf8f012ba397bfee63adbc 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/collect/DriverSpecificWaitingQueriesSelectionPolicy.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/collect/DriverSpecificWaitingQueriesSelectionPolicyFactory.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/collect/EstimatedImmutableQueryCollection.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/collect/ImmutableQueryCollection.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/collect/WaitingQueriesSelectionPolicy.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/constraint/MaxConcurrentDriverQueriesConstraint.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/constraint/MaxConcurrentDriverQueriesConstraintFactory.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/constraint/QueryLaunchingConstraint.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/FactPartitionBasedQueryCost.java
 7fa5cdb55959a44b52a29884fd629c2479fdfb96 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/QueryCost.java
 be7232134b59f7126edba569358389a9c26a5c74 
  lens-server-api/src/main/java/org/apache/lens/server/api/util/LensUtil.java 
f9262994debe0b943123d13c58a22c10b2015e80 
  
lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java 
b52b08ad78a4c74c61376fb3c6bc6284f38b0de9 
  
lens-server-api/src/test/java/org/apache/lens/server/api/query/collect/DriverSpecificWaitingQueriesSelectionPolicyTest.java
 PRE-CREATION 
  
lens-server-api/src/test/java/org/apache/lens/server/api/query/constraint/MaxConcurrentDriverQueriesConstraintTest.java
 PRE-CREATION 
  
lens-server-api/src/test/java/org/apache/lens/server/api/query/cost/TestFactPartitionBasedQueryCost.java
 0ab0b0ec7c83c1eac8d61c8a30ecec5e9dc2e322 
  lens-server/pom.xml 6ac30a52cc8c1c58bf8e92bb77df358db6e22a3e 
  
lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java
 39f9f5216acf6e1be7cca6a0851152a78ba66176 
  lens-server/src/main/java/org/apache/lens/server/query/LensServerDAO.java 
190435036c5cf8f009d7fbd536ef1743b70c22d9 
  
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java
 35112367b1b40309c04e6748f7ae69ceac959a28 
  
lens-server/src/main/java/org/apache/lens/server/query/collect/DefaultEstimatedQueryCollection.java
 PRE-CREATION 
  
lens-server/src/main/java/org/apache/lens/server/query/collect/DefaultQueryCollection.java
 PRE-CREATION 
  
lens-server/src/main/java/org/apache/lens/server/query/collect/IntersectingWaitingQueriesSelector.java
 PRE-CREATION 
  
lens-server/src/main/java/org/apache/lens/server/query/collect/MutableQueryCollection.java
 PRE-CREATION 
  
lens-server/src/main/java/org/apache/lens/server/query/collect/QueryCollection.java
 PRE-CREATION 
  
lens-server/src/main/java/org/apache/lens/server/query/collect/ThreadSafeEstimatedQueryCollection.java
 PRE-CREATION 
  
lens-server/src/main/java/org/apache/lens/server/query/collect/ThreadSafeQueryCollection.java
 PRE-CREATION 
  
lens-server/src/main/java/org/apache/lens/server/query/collect/UserSpecificWaitingQueriesSelectionPolicy.java
 PRE-CREATION 
  
lens-server/src/main/java/org/apache/lens/server/query/collect/UserSpecificWaitingQueriesSelectionPolicyFactory.java
 PRE-CREATION 
  
lens-server/src/main/java/org/apache/lens/server/query/collect/WaitingQueriesSelector.java
 PRE-CREATION 
  
lens-server/src/main/java/org/apache/lens/server/query/constraint/DefaultQueryLaunchingConstraintsChecker.java
 PRE-CREATION 
  
lens-server/src/main/java/org/apache/lens/server/query/constraint/QueryLaunchingConstraintsChecker.java
 PRE-CREATION 
  
lens-server/src/main/java/org/apache/lens/server/query/constraint/TotalQueryCostCeilingConstraint.java
 PRE-CREATION 
  
lens-server/src/main/java/org/apache/lens/server/query/constraint/TotalQueryCostCeilingConstraintFactory.java
 PRE-CREATION 
  
lens-server/src/main/java/org/apache/lens/server/util/FairPriorityBlockingQueue.java
 PRE-CREATION 
  lens-server/src/main/java/org/apache/lens/server/util/UtilityMethods.java 
715347fab82b5d9d4ad673c45e72900b9a95fc81 
  lens-server/src/main/resources/lensserver-default.xml 
2b540b828a976378bdfbd238e8427a22941fb7e8 
  
lens-server/src/test/java/org/apache/lens/server/query/collect/DefaultEstimatedQueryCollectionTest.java
 PRE-CREATION 
  
lens-server/src/test/java/org/apache/lens/server/query/collect/DefaultQueryCollectionTest.java
 PRE-CREATION 
  
lens-server/src/test/java/org/apache/lens/server/query/collect/IntersectingWaitingQueriesSelectorTest.java
 PRE-CREATION 
  
lens-server/src/test/java/org/apache/lens/server/query/collect/QueryCollectUtil.java
 PRE-CREATION 
  
lens-server/src/test/java/org/apache/lens/server/query/collect/ThreadSafetyTest.java
 PRE-CREATION 
  
lens-server/src/test/java/org/apache/lens/server/query/collect/UserSpecificWaitingQueriesSelectionPolicyTest.java
 PRE-CREATION 
  
lens-server/src/test/java/org/apache/lens/server/query/constraint/DefaultQueryLaunchingConstraintsCheckerTest.java
 PRE-CREATION 
  
lens-server/src/test/java/org/apache/lens/server/query/constraint/TotalQueryCostCeilingConstraintTest.java
 PRE-CREATION 
  lens-server/src/test/resources/lens-site.xml 
3bcbf0e3e44d986a24c00cad84121be72596c64d 
  lens-server/src/test/resources/log4j.properties 
e0f9daa62c7d88f5044803c5a0ce2ffb2ac9315b 
  src/site/apt/admin/config.apt c5bf70c612a8d9bc383d0031e5cb51338cbd1da8 
  src/site/apt/admin/hivedriver-config.apt 
b668e160f4fd1ce05179bb50c7dc6264ea6101e2 
  src/site/apt/admin/jdbcdriver-config.apt 
b3d25f6751dd030a4ae818845a4a504ca41d7895 
  src/site/apt/user/index.apt d48c7347314876989cf8de8f3e330dc972e3ec5d 

Diff: https://reviews.apache.org/r/36393/diff/


Testing
-------

All Test cases passed:

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] Lens Checkstyle Rules ............................. SUCCESS [3.514s]
[INFO] Lens .............................................. SUCCESS [4.091s]
[INFO] Lens API .......................................... SUCCESS [29.290s]
[INFO] Lens API for server and extensions ................ SUCCESS [30.638s]
[INFO] Lens Cube ......................................... SUCCESS [5:35.451s]
[INFO] Lens DB storage ................................... SUCCESS [26.042s]
[INFO] Lens Query Library ................................ SUCCESS [21.532s]
[INFO] Lens Hive Driver .................................. SUCCESS [3:37.060s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [49.002s]
[INFO] Lens Server ....................................... SUCCESS [23:41.881s]
[INFO] Lens client ....................................... SUCCESS [1:04.296s]
[INFO] Lens CLI .......................................... SUCCESS [4:34.347s]
[INFO] Lens Examples ..................................... SUCCESS [15.041s]
[INFO] Lens Distribution ................................. SUCCESS [21.181s]
[INFO] Lens ML Lib ....................................... SUCCESS [3:33.233s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [12.803s]
[INFO] Lens Regression ................................... SUCCESS [17.566s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 45:57.904s
[INFO] Finished at: Wed Jul 15 14:09:04 IST 2015
[INFO] Final Memory: 120M/324M
[INFO] ------------------------------------------------------------------------


Thanks,

Himanshu Gahlaut

Reply via email to