> On July 20, 2015, 1:48 p.m., Raju Bairishetti wrote: > > lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java, > > line 150 > > <https://reviews.apache.org/r/36178/diff/5/?file=1016041#file1016041line150> > > > > Can we avoid the checks for each file system scheme(file, hdfs, s3...)? > > Can we find a way to get the scheme from the filepath itself and make > > changes accordingly? > > > > Hadoop FileSystem returns scheme using getScheme() method. > > > > @prongs @amareshwari thoughts?
Cannot use hadoop's filesystem until the URI is formatted, and the CLI appends a local dir prefix to the path and replaces all double slashes // with single slashes /. Have avoided to some extent by adding :/// for all uri's in general and special handling for hdfs that would expect :// Currently it wouldnot support s3/s3n patch with userid and key mentioned with :// Need to devise some strategy for it. Let me know your opinion on this. > On July 20, 2015, 1:48 p.m., Raju Bairishetti wrote: > > lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java, > > line 151 > > <https://reviews.apache.org/r/36178/diff/5/?file=1016041#file1016041line151> > > > > Can we move this above and use *newPath* wherever we use path.getPath()? Changed design of util method. Let me know if it looks good. > On July 20, 2015, 1:48 p.m., Raju Bairishetti wrote: > > lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java, > > line 155 > > <https://reviews.apache.org/r/36178/diff/5/?file=1016041#file1016041line155> > > > > Yes, but we are already checking whether the path contains **file:/**. > > Looks like it is a redundant check. +1. My Bad. Fixed now. - Yash ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36178/#review92264 ----------------------------------------------------------- On July 22, 2015, 2:29 p.m., Yash Sharma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36178/ > ----------------------------------------------------------- > > (Updated July 22, 2015, 2:29 p.m.) > > > Review request for lens. > > > Bugs: LENS-634 > https://issues.apache.org/jira/browse/LENS-634 > > > Repository: lens > > > Description > ------- > > Added changes for file name suggestions on Tab. Changed String file paths to > File. > > > https://issues.apache.org/jira/browse/LENS-634 > > > Diffs > ----- > > lens-api/src/main/java/org/apache/lens/api/util/ApiUtilityMethods.java > PRE-CREATION > lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java > bdfae24 > lens-cli/src/main/java/org/apache/lens/cli/commands/LensCRUDCommand.java > 9cb7d69 > > lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java > 8b4face > lens-cli/src/main/java/org/apache/lens/cli/commands/LensCubeCommands.java > 6ba702f > > lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionCommands.java > de022c1 > > lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionTableCommands.java > 5fd80a1 > lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java > 5493dba > lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java > c48fabd > > lens-cli/src/main/java/org/apache/lens/cli/commands/LensStorageCommands.java > 928120a > > lens-cli/src/main/java/org/apache/lens/cli/commands/PhysicalTableCrudCommand.java > c505680 > > lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java > 7503221 > lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java > 73661e1 > lens-cli/src/test/java/org/apache/lens/cli/TestLensDatabaseCommands.java > b6f96e6 > lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java > a22862e > > lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java > 56e962d > lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java > fa342c8 > > lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommandsWithMissingWeight.java > 73f3a78 > lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java > 46e28a9 > lens-cli/src/test/java/org/apache/lens/cli/TestLensStorageCommands.java > 3a04ec6 > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java > 47d27d0 > > lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java > a5033fe > lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java > 92687c3 > src/site/apt/user/cli.apt 63f2b3f > > Diff: https://reviews.apache.org/r/36178/diff/ > > > Testing > ------- > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 3.756 > s] > [INFO] Lens ............................................... SUCCESS [ 10.092 > s] > [INFO] Lens API ........................................... SUCCESS [ 22.157 > s] > [INFO] Lens API for server and extensions ................. SUCCESS [ 20.357 > s] > [INFO] Lens Cube .......................................... SUCCESS [03:36 > min] > [INFO] Lens DB storage .................................... SUCCESS [ 19.628 > s] > [INFO] Lens Query Library ................................. SUCCESS [ 14.736 > s] > [INFO] Lens Hive Driver ................................... SUCCESS [02:31 > min] > [INFO] Lens Driver for JDBC ............................... SUCCESS [ 34.394 > s] > [INFO] Lens Server ........................................ SUCCESS [04:49 > min] > [INFO] Lens client ........................................ SUCCESS [ 37.127 > s] > [INFO] Lens CLI ........................................... SUCCESS [02:43 > min] > [INFO] Lens Examples ...................................... SUCCESS [ 9.946 > s] > [INFO] Lens Distribution .................................. SUCCESS [ 7.965 > s] > [INFO] Lens ML Lib ........................................ SUCCESS [01:24 > min] > [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.952 > s] > [INFO] Lens Regression .................................... SUCCESS [ 12.781 > s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 18:21 min > [INFO] Finished at: 2015-07-22T19:27:26+05:30 > [INFO] Final Memory: 130M/395M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Yash Sharma > >
