> On July 27, 2015, 10:41 a.m., Amareshwari Sriramadasu wrote: > > lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java, > > line 357 > > <https://reviews.apache.org/r/36690/diff/5/?file=1020910#file1020910line357> > > > > Can you update doc wrt what is returned? Applies to all changed methods. > > > > Also, should this return all partitions added or returning the number > > of partitions added is enough?
Returning number of partitions now. Added doc. - Rajat ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36690/#review93073 ----------------------------------------------------------- On July 24, 2015, 5:41 p.m., Rajat Khandelwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36690/ > ----------------------------------------------------------- > > (Updated July 24, 2015, 5:41 p.m.) > > > Review request for lens. > > > Bugs: LENS-686 > https://issues.apache.org/jira/browse/LENS-686 > > > Repository: lens > > > Description > ------- > > > Diffs > ----- > > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java > 0ebc707dcbec895dae3af60feab1eaf0ab657048 > lens-cube/src/main/java/org/apache/lens/cube/metadata/Storage.java > 873aa490e37c0306dec57cda31880ffa5a332045 > > lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java > bd31f8243f4871f1d2d6fe76997287f9be82b6ab > > lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java > 646de8c1b53fb7cbd85895a4ad672e68311931f0 > lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java > 2d0eba23750542f1dd916d3c62af656c4dc2767c > > lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java > d6ef04d064c040a9131d5b2efbbce90f467f6841 > > lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java > 22dfd553d47177d246efa772df34119f653cabc0 > > Diff: https://reviews.apache.org/r/36690/diff/ > > > Testing > ------- > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.969s] > [INFO] Lens .............................................. SUCCESS [3.037s] > [INFO] Lens API .......................................... SUCCESS [23.808s] > [INFO] Lens API for server and extensions ................ SUCCESS [19.100s] > [INFO] Lens Cube ......................................... SUCCESS [6:37.899s] > [INFO] Lens DB storage ................................... SUCCESS [19.622s] > [INFO] Lens Query Library ................................ SUCCESS [15.168s] > [INFO] Lens Hive Driver .................................. SUCCESS [2:49.229s] > [INFO] Lens Driver for JDBC .............................. SUCCESS [34.989s] > [INFO] Lens Server ....................................... SUCCESS [5:22.255s] > [INFO] Lens client ....................................... SUCCESS [35.232s] > [INFO] Lens CLI .......................................... SUCCESS [2:47.529s] > [INFO] Lens Examples ..................................... SUCCESS [10.355s] > [INFO] Lens Distribution ................................. SUCCESS [10.164s] > [INFO] Lens ML Lib ....................................... SUCCESS [1:28.550s] > [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.826s] > [INFO] Lens Regression ................................... SUCCESS [11.717s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 22:13.285s > [INFO] Finished at: Fri Jul 24 09:08:03 UTC 2015 > [INFO] Final Memory: 169M/928M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Rajat Khandelwal > >
