----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36981/#review94363 -----------------------------------------------------------
Ship it! lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java (line 220) <https://reviews.apache.org/r/36981/#comment148937> Is the typecast necessary? - Rajat Khandelwal On Aug. 5, 2015, 6:28 p.m., Amareshwari Sriramadasu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36981/ > ----------------------------------------------------------- > > (Updated Aug. 5, 2015, 6:28 p.m.) > > > Review request for lens. > > > Bugs: LENS-666 > https://issues.apache.org/jira/browse/LENS-666 > > > Repository: lens > > > Description > ------- > > Changes include : > - Remove log4j dependency > - Move existing log4j.propertise to logback.xml > - CLI verbose/debug logger moved to logback > - Move QueryExecutionStat loggers to logback > - Remove transitive log4j dependencies ( couldnt remove provided ones as some > tests are failing) > - update licenses wrt logback > > > Diffs > ----- > > bin-dist-files/LICENSE 5d593ad > bin-dist-files/NOTICE 1fbb09c > lens-api/pom.xml e1b763d > > lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java > c059f30 > lens-client/pom.xml d83f830 > lens-cube/pom.xml 36b508a > lens-cube/src/test/resources/log4j.properties deaf1e1 > lens-cube/src/test/resources/logback.xml PRE-CREATION > lens-dist/pom.xml cea9906 > lens-driver-hive/src/test/resources/log4j.properties 2c2dc45 > lens-driver-hive/src/test/resources/logback.xml PRE-CREATION > lens-driver-jdbc/pom.xml 2cb7f58 > lens-query-lib/src/test/resources/log4j.properties a69d13a > lens-query-lib/src/test/resources/logback.xml PRE-CREATION > lens-server-api/pom.xml 6822976 > lens-server/pom.xml 5174607 > > lens-server/src/main/java/org/apache/lens/server/LensServletContextListener.java > 0945a35 > > lens-server/src/main/java/org/apache/lens/server/stats/event/LoggableLensStatistics.java > e8a7b0c > > lens-server/src/main/java/org/apache/lens/server/stats/store/log/StatisticsLogFileScannerTask.java > 4144416 > > lens-server/src/main/java/org/apache/lens/server/stats/store/log/StatisticsLogLayout.java > 67a163c > > lens-server/src/main/java/org/apache/lens/server/stats/store/log/StatisticsLogRollupHandler.java > 9ff878c > lens-server/src/main/resources/lensserver-default.xml 6af8d10 > lens-server/src/main/webapp/WEB-INF/log4j.properties f5fdffa > lens-server/src/main/webapp/WEB-INF/web.xml 4ee54a6 > > lens-server/src/test/java/org/apache/lens/server/healthcheck/TestHealthChecks.java > 3573a1e > > lens-server/src/test/java/org/apache/lens/server/stats/TestLogStatisticsStore.java > c8a0ea5 > > lens-server/src/test/java/org/apache/lens/server/stats/TestStatisticsLogFileScannerTask.java > 819c62a > lens-server/src/test/resources/log4j.properties 9cc1e36 > lens-server/src/test/resources/logback.xml PRE-CREATION > pom.xml 3c98077 > src/site/apt/admin/config.apt 2e1dbe7 > src/site/apt/admin/monitoring.apt 3ad2f92 > src/site/apt/lenshome/install-and-run.apt 8016491 > tools/conf-pseudo-distr/client/log4j.properties 3756cf7 > tools/conf-pseudo-distr/client/logback.xml PRE-CREATION > tools/conf-pseudo-distr/server/log4j.properties 2b04ea5 > tools/conf-pseudo-distr/server/logback.xml PRE-CREATION > tools/conf/client/log4j.properties 3756cf7 > tools/conf/client/logback.xml PRE-CREATION > tools/conf/server/log4j.properties 2b04ea5 > tools/conf/server/logback.xml PRE-CREATION > > Diff: https://reviews.apache.org/r/36981/diff/ > > > Testing > ------- > > Tested query log fetching > Tested query execution statistics > Tested debug/verbose logging > > Dependencies : > client$ ls lib/*log* > lib/log4j-over-slf4j-1.7.6.jar lib/logback-classic-1.1.3.jar > lib/logback-core-1.1.3.jar > client $ ls lib/*slf* > lib/jcl-over-slf4j-1.7.6.jar lib/log4j-over-slf4j-1.7.6.jar > lib/slf4j-api-1.7.6.jar > > server $ ls webapp/lens-server/WEB-INF/lib/*log* > webapp/lens-server/WEB-INF/lib/log4j-over-slf4j-1.7.6.jar > webapp/lens-server/WEB-INF/lib/logback-classic-1.1.3.jar > webapp/lens-server/WEB-INF/lib/logback-core-1.1.3.jar > > server $ ls webapp/lens-server/WEB-INF/lib/*slf* > webapp/lens-server/WEB-INF/lib/jcl-over-slf4j-1.7.6.jar > webapp/lens-server/WEB-INF/lib/log4j-over-slf4j-1.7.6.jar > webapp/lens-server/WEB-INF/lib/jul-to-slf4j-1.7.6.jar > webapp/lens-server/WEB-INF/lib/slf4j-api-1.7.6.jar > > Some issues in lens-server logs: > $ ls logs/ > c6c970ca-5034-4266-9cfc-8a9b8efe30ee.log lensserver-requests.log > lensserver.out.2015080315161438595208 unknown.log > lensserver-query-status.log lensserver.log > query-stats.log > > > unknown.log is getting created with all the logs that does not belong to > > query logs. > > There are some logback filters that can be added for avoiding this, but they > are coming with their own dependencies to add filter. will see if i can spend > more time on this as part of this jira. if not, will do a follow up. > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.407s] > [INFO] Lens .............................................. SUCCESS [3.400s] > [INFO] Lens API .......................................... SUCCESS [22.209s] > [INFO] Lens API for server and extensions ................ SUCCESS [19.485s] > [INFO] Lens Cube ......................................... SUCCESS [6:25.516s] > [INFO] Lens DB storage ................................... SUCCESS [20.748s] > [INFO] Lens Query Library ................................ SUCCESS [15.001s] > [INFO] Lens Hive Driver .................................. SUCCESS [2:50.255s] > [INFO] Lens Driver for JDBC .............................. SUCCESS [35.993s] > [INFO] Lens Elastic Search Driver ........................ SUCCESS [15.543s] > [INFO] Lens Server ....................................... SUCCESS [5:34.272s] > [INFO] Lens client ....................................... SUCCESS [37.631s] > [INFO] Lens CLI .......................................... SUCCESS [2:41.047s] > [INFO] Lens Examples ..................................... SUCCESS [9.848s] > [INFO] Lens Distribution ................................. SUCCESS [8.638s] > [INFO] Lens ML Lib ....................................... SUCCESS [1:25.234s] > [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.887s] > [INFO] Lens Regression ................................... SUCCESS [10.484s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 22:20.640s > [INFO] Finished at: Wed Aug 05 12:46:55 UTC 2015 > [INFO] Final Memory: 198M/2294M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Amareshwari Sriramadasu > >
