----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36938/#review94515 -----------------------------------------------------------
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java (line 692) <https://reviews.apache.org/r/36938/#comment149140> Assertion below would still fail if ctx is constructed from FinishedLensQuery. Can we move the assertion to a running query instead of finished query? - Amareshwari Sriramadasu On Aug. 7, 2015, 9:32 a.m., Rajat Khandelwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36938/ > ----------------------------------------------------------- > > (Updated Aug. 7, 2015, 9:32 a.m.) > > > Review request for lens. > > > Bugs: LENS-684 > https://issues.apache.org/jira/browse/LENS-684 > > > Repository: lens > > > Description > ------- > > TestQueryService#testExecuteAsync: > > Below asserts will fail, if the query context is removed by QueryPurger > thread before the test running test case could retrieve it from allQueries > collection using queryService. Provided lens.server.max.finished.queries=0 in > lens-site.xml > > {code} > > QueryContext ctx = > queryService.getQueryContext(lensQuery.getQueryHandle()); > assertNotNull(ctx.getPhase1RewrittenQuery()); > assertEquals(ctx.getPhase1RewrittenQuery(), ctx.getUserQuery()); > > {code} > > These were added in LENS-24 Commit: > https://github.com/apache/incubator-lens/commit/689c9a99b112b21e9ecba9a8461cf9672b88ba2f > > > Diffs > ----- > > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java > 2983db418e1361715b79a85426661b64565a45c0 > > lens-server/src/test/java/org/apache/lens/server/LensAllApplicationJerseyTest.java > a067924fc555160981b2d9ca32145ace449f5854 > > lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java > beaa2474708a91799f171b8b40c60e2b4d76079e > > lens-server/src/test/java/org/apache/lens/server/query/TestResultFormatting.java > 46a01f81c9a122b0371ef9faee62d73c144f9099 > lens-server/src/test/resources/lens-site.xml > 6179c417a8c1ec0dfb2eb01e0e024426a7494e63 > > Diff: https://reviews.apache.org/r/36938/diff/ > > > Testing > ------- > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.970s] > [INFO] Lens .............................................. SUCCESS [2.769s] > [INFO] Lens API .......................................... SUCCESS [21.835s] > [INFO] Lens API for server and extensions ................ SUCCESS [22.005s] > [INFO] Lens Cube ......................................... SUCCESS [5:59.384s] > [INFO] Lens DB storage ................................... SUCCESS [20.477s] > [INFO] Lens Query Library ................................ SUCCESS [13.952s] > [INFO] Lens Hive Driver .................................. SUCCESS [2:46.394s] > [INFO] Lens Driver for JDBC .............................. SUCCESS [35.238s] > [INFO] Lens Server ....................................... SUCCESS [5:22.280s] > [INFO] Lens client ....................................... SUCCESS [34.721s] > [INFO] Lens CLI .......................................... SUCCESS [2:35.788s] > [INFO] Lens Examples ..................................... SUCCESS [8.684s] > [INFO] Lens Distribution ................................. SUCCESS [8.485s] > [INFO] Lens ML Lib ....................................... SUCCESS [1:18.588s] > [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.698s] > [INFO] Lens Regression ................................... SUCCESS [11.397s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 21:06.507s > [INFO] Finished at: Thu Jul 30 13:53:45 UTC 2015 > [INFO] Final Memory: 175M/1194M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Rajat Khandelwal > >
