-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37293/#review94883
-----------------------------------------------------------



lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java (line 
1194)
<https://reviews.apache.org/r/37293/#comment149558>

    Should `getFactOrDimtableStorageTableName` take care of doing 
`toLowerCase()`?


- Rajat Khandelwal


On Aug. 11, 2015, 11:05 a.m., Amareshwari Sriramadasu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37293/
> -----------------------------------------------------------
> 
> (Updated Aug. 11, 2015, 11:05 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-711
>     https://issues.apache.org/jira/browse/LENS-711
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Changes include :
> - Add ability to specify multiple chain columns
> - Add rewriter capability to understand multiple chains for a column
> - Rewriter tests added
> - End to end test in lens-cli
> 
> 
> Diffs
> -----
> 
>   lens-api/src/main/resources/cube-0.1.xsd e6cb87d 
>   lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java 
> 9912eef 
>   lens-cli/src/test/resources/sample-cube.xml f0eba57 
>   lens-cli/src/test/resources/test-detail.xml PRE-CREATION 
>   
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java
>  f0a0dfe 
>   
> lens-cube/src/main/java/org/apache/lens/cube/metadata/ReferencedDimAtrribute.java
>  742c6a0 
>   
> lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/EndsAndHolesPartitionTimeline.java
>  9d5e264 
>   
> lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/StoreAllPartitionTimeline.java
>  c82da7b 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java
>  50a4d53 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java
>  4a95d5a 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/FieldValidator.java 
> 03377dd 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java 
> 7d04d19 
>   
> lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java
>  077396e 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 
> 1d4e7dd 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java 
> f65bd28 
>   
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java
>  7d9183c 
>   
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriterWithQuery.java
>  00d92b5 
>   lens-examples/src/main/resources/sales-cube.xml 4923aa3 
>   lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java 
> 70bd20d 
>   
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java
>  6e3afc6 
> 
> Diff: https://reviews.apache.org/r/37293/diff/
> 
> 
> Testing
> -------
> 
> Verified examples
> 
> [INFO] 
> ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.563s]
> [INFO] Lens .............................................. SUCCESS [3.148s]
> [INFO] Lens API .......................................... SUCCESS [22.225s]
> [INFO] Lens API for server and extensions ................ SUCCESS [21.040s]
> [INFO] Lens Cube ......................................... SUCCESS [5:05.342s]
> [INFO] Lens DB storage ................................... SUCCESS [19.800s]
> [INFO] Lens Query Library ................................ SUCCESS [15.939s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:52.849s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [37.485s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [15.515s]
> [INFO] Lens Server ....................................... SUCCESS [5:39.271s]
> [INFO] Lens client ....................................... SUCCESS [34.686s]
> [INFO] Lens CLI .......................................... SUCCESS [2:38.436s]
> [INFO] Lens Examples ..................................... SUCCESS [8.615s]
> [INFO] Lens Distribution ................................. SUCCESS [8.438s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:19.479s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.905s]
> [INFO] Lens Regression ................................... SUCCESS [10.500s]
> [INFO] 
> ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] 
> ------------------------------------------------------------------------
> [INFO] Total time: 20:58.156s
> [INFO] Finished at: Tue Aug 11 05:21:11 UTC 2015
> [INFO] Final Memory: 189M/1543M
> [INFO] 
> ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Amareshwari Sriramadasu
> 
>

Reply via email to