----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37478/#review95703 -----------------------------------------------------------
src/site/apt/user/olap-cube.apt (line 143) <https://reviews.apache.org/r/37478/#comment150798> Did not understand - "Logical drop the concern of of join chains fully and expressions partially." src/site/apt/user/olap-cube.apt (line 153) <https://reviews.apache.org/r/37478/#comment150799> Facts are defined below. Similar to facts is missing information here. src/site/apt/user/olap-cube.apt (line 159) <https://reviews.apache.org/r/37478/#comment150800> "derived cubes will only act as constraints" does not make sense here. You can Derived cube will inherit all its base cube facts. src/site/apt/user/olap-cube.apt (line 169) <https://reviews.apache.org/r/37478/#comment150803> Seems Update Period section is moved above, change this accordingly. src/site/apt/user/olap-cube.apt (line 204) <https://reviews.apache.org/r/37478/#comment150804> Please add the below as well : ---- Dimension storage table is the physical dimension table for the associated storage. Dimension storage table can have snapshot dumps at specified regular intervals or a table with no dumps, so the storage table can have zero or one update period. ---- Also, change "Dimension storage tables are supposed to be snapshotted" to the following applies to snapped dimtable storage tables. src/site/apt/user/olap-cube.apt (line 221) <https://reviews.apache.org/r/37478/#comment150805> typo unlike ? src/site/apt/user/olap-cube.apt (line 230) <https://reviews.apache.org/r/37478/#comment150812> typo - "there is need" ? src/site/apt/user/olap-cube.apt (line 235) <https://reviews.apache.org/r/37478/#comment150816> Please add following in wiki, if they are already not there. And timeline being present in properties should not highlighted to users. They should be encouraged to use cli to see timelines, instead of properties. The implementation can change to use timelines somewhere else in later versions. - Amareshwari Sriramadasu On Aug. 18, 2015, 7:12 a.m., Rajat Khandelwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37478/ > ----------------------------------------------------------- > > (Updated Aug. 18, 2015, 7:12 a.m.) > > > Review request for lens. > > > Bugs: LENS-490 > https://issues.apache.org/jira/browse/LENS-490 > > > Repository: lens > > > Description > ------- > > This task is to document the partition timeline. > It should document who are the users of it, what is timeline, > how to to use the cache, what are the defaults and why they are chosen, > how/when to migrate, how/when to update existing timeline. > > > Diffs > ----- > > src/site/apt/user/index.apt d48c7347314876989cf8de8f3e330dc972e3ec5d > src/site/apt/user/olap-cube.apt 87fd659d28ce305460da43905a147f66b7b28824 > > Diff: https://reviews.apache.org/r/37478/diff/ > > > Testing > ------- > > > Thanks, > > Rajat Khandelwal > >
