> On Aug. 20, 2015, 2:33 p.m., Raju Bairishetti wrote: > > lens-cube/src/main/java/org/apache/lens/cube/metadata/BaseDimAttribute.java, > > line 86 > > <https://reviews.apache.org/r/37522/diff/4/?file=1044131#file1044131line86> > > > > Can we add numOfDistinctValues proeprty to props map for inline dim > > attributes eventhough numOfDistinctValues is absent?
numOfDistinctValues would be already set to size of values in the constructor. There wont be any case of numOfDistinctValues being absent, when values exist. > On Aug. 20, 2015, 2:33 p.m., Raju Bairishetti wrote: > > lens-cube/src/main/java/org/apache/lens/cube/metadata/BaseDimAttribute.java, > > line 100 > > <https://reviews.apache.org/r/37522/diff/4/?file=1044131#file1044131line100> > > > > Can we set numOfDistinctValues for inline dim attributes even if > > numOfDistinctValues property is not present in props? numOfDistinctValues would be already set to size of values when it was serialized. There wont be any case of numOfDistinctValues being absent, when values exist. - Amareshwari ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37522/#review95954 ----------------------------------------------------------- On Aug. 19, 2015, 10:21 a.m., Amareshwari Sriramadasu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37522/ > ----------------------------------------------------------- > > (Updated Aug. 19, 2015, 10:21 a.m.) > > > Review request for lens. > > > Bugs: LENS-731 > https://issues.apache.org/jira/browse/LENS-731 > > > Repository: lens > > > Description > ------- > > Changes include : > - Cube xsd update > - Removed InlineDimAttribute class and moved values to BaseDimAttribute > directly. Inline values can be provided for any attribute - even ref > attribute. > - Added tests > - Updated examples > > > Diffs > ----- > > lens-api/src/main/resources/cube-0.1.xsd 02ea2d1 > lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java > 3a7c29a > lens-cli/src/test/resources/test-dimension.xml a9b7c08 > lens-cube/src/main/java/org/apache/lens/cube/metadata/BaseDimAttribute.java > f5a84d8 > > lens-cube/src/main/java/org/apache/lens/cube/metadata/InlineDimAttribute.java > e8d2fae > lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java > 59a30a9 > > lens-cube/src/main/java/org/apache/lens/cube/metadata/ReferencedDimAtrribute.java > a60281b > > lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java > 5d66039 > lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java > ae8984f > lens-examples/src/main/resources/customer.xml 1b4f854 > lens-examples/src/main/resources/sales-cube.xml 2d67f5c > lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java > d6c4f17 > > lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java > 308ce33 > > Diff: https://reviews.apache.org/r/37522/diff/ > > > Testing > ------- > > Verified examples > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.835s] > [INFO] Lens .............................................. SUCCESS [2.901s] > [INFO] Lens API .......................................... SUCCESS [22.697s] > [INFO] Lens API for server and extensions ................ SUCCESS [19.552s] > [INFO] Lens Cube ......................................... SUCCESS [5:10.743s] > [INFO] Lens DB storage ................................... SUCCESS [23.538s] > [INFO] Lens Query Library ................................ SUCCESS [18.058s] > [INFO] Lens Hive Driver .................................. SUCCESS [3:04.191s] > [INFO] Lens Driver for JDBC .............................. SUCCESS [37.900s] > [INFO] Lens Elastic Search Driver ........................ SUCCESS [17.861s] > [INFO] Lens Server ....................................... SUCCESS [5:37.848s] > [INFO] Lens client ....................................... SUCCESS [36.515s] > [INFO] Lens CLI .......................................... SUCCESS [2:38.272s] > [INFO] Lens Examples ..................................... SUCCESS [9.977s] > [INFO] Lens Distribution ................................. SUCCESS [8.462s] > [INFO] Lens ML Lib ....................................... SUCCESS [1:20.600s] > [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.974s] > [INFO] Lens Regression ................................... SUCCESS [11.353s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 21:25.170s > [INFO] Finished at: Wed Aug 19 10:19:25 UTC 2015 > [INFO] Final Memory: 203M/2127M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Amareshwari Sriramadasu > >
