> On Aug. 19, 2015, 11:08 a.m., Amareshwari Sriramadasu wrote: > > lens-ui/app/adapters/AdhocQueryAdapter.js, line 9 > > <https://reviews.apache.org/r/37530/diff/2/?file=1041958#file1041958line9> > > > > Not accepting adhoc queries on dimensions? > > > > do we need metastore/dimensions as well ? > > Ankeet Maini wrote: > When I fetch cubes, its measures and dimensions come as well, and are > discoverable and people can query them. Not sure if I understand your > question completely! > > Amareshwari Sriramadasu wrote: > Parallel to Cubes (which have measures and dim-attributes), we have > Dimensions which have dimension tables. I'm talking about querying them > directly. > > Ankeet Maini wrote: > As per the current implementation and AFAIK we can query the dimensions > via native table, because for every dimension created a native table would've > been created. > > Amareshwari Sriramadasu wrote: > We can query dimensions similar to cubes with cube select. See example > queries > https://github.com/apache/incubator-lens/blob/master/lens-examples/src/main/resources/dimension-queries.sql. > It would good to explore and query dimensions as well through ui.
Yes, on the left side you're showing cubes which on click show the queryable fields. Dimensions(not dim tables or native tables) also have queryable fields. Secondly, native tables basically take away the abstractions provided to the user. They are only for debugging purposes, we're not supposed to build any feature depending on the "functionality" of native tables. Native tables are not a "functionality", they are a back-door pass. - Rajat ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37530/#review95819 ----------------------------------------------------------- On Aug. 20, 2015, 3:08 p.m., Ankeet Maini wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37530/ > ----------------------------------------------------------- > > (Updated Aug. 20, 2015, 3:08 p.m.) > > > Review request for lens, Amareshwari Sriramadasu, Jaideep dhok, Rajat > Khandelwal, sharad agarwal, and Yash Sharma. > > > Repository: lens > > > Description > ------- > > LENS-629 - A new improved web client > > > Diffs > ----- > > .gitignore d0fa424 > lens-ui/README.markdown PRE-CREATION > lens-ui/app/actions/AdhocQueryActions.js PRE-CREATION > lens-ui/app/actions/LoginActions.js PRE-CREATION > lens-ui/app/adapters/AdhocQueryAdapter.js PRE-CREATION > lens-ui/app/adapters/AuthenticationAdapter.js PRE-CREATION > lens-ui/app/adapters/BaseAdapter.js PRE-CREATION > lens-ui/app/app.js PRE-CREATION > lens-ui/app/components/AboutComponent.js PRE-CREATION > lens-ui/app/components/AdhocQueryComponent.js PRE-CREATION > lens-ui/app/components/AppComponent.js PRE-CREATION > lens-ui/app/components/CubeSchemaComponent.js PRE-CREATION > lens-ui/app/components/CubeTreeComponent.js PRE-CREATION > lens-ui/app/components/DatabaseComponent.js PRE-CREATION > lens-ui/app/components/HeaderComponent.js PRE-CREATION > lens-ui/app/components/LoaderComponent.js PRE-CREATION > lens-ui/app/components/LoginComponent.js PRE-CREATION > lens-ui/app/components/LogoutComponent.js PRE-CREATION > lens-ui/app/components/QueryBoxComponent.js PRE-CREATION > lens-ui/app/components/QueryDetailResultComponent.js PRE-CREATION > lens-ui/app/components/QueryOperationsComponent.js PRE-CREATION > lens-ui/app/components/QueryPreviewComponent.js PRE-CREATION > lens-ui/app/components/QueryResultsComponent.js PRE-CREATION > lens-ui/app/components/RequireAuthenticationComponent.js PRE-CREATION > lens-ui/app/components/SidebarComponent.js PRE-CREATION > lens-ui/app/components/TableSchemaComponent.js PRE-CREATION > lens-ui/app/components/TableTreeComponent.js PRE-CREATION > lens-ui/app/constants/AdhocQueryConstants.js PRE-CREATION > lens-ui/app/constants/AppConstants.js PRE-CREATION > lens-ui/app/dispatcher/AppDispatcher.js PRE-CREATION > lens-ui/app/stores/AdhocQueryStore.js PRE-CREATION > lens-ui/app/stores/CubeStore.js PRE-CREATION > lens-ui/app/stores/DatabaseStore.js PRE-CREATION > lens-ui/app/stores/TableStore.js PRE-CREATION > lens-ui/app/stores/UserStore.js PRE-CREATION > lens-ui/app/styles/css/global.css PRE-CREATION > lens-ui/app/styles/css/login.css PRE-CREATION > lens-ui/app/styles/css/query-component.css PRE-CREATION > lens-ui/app/styles/css/tree.css PRE-CREATION > lens-ui/app/styles/less/globals.less PRE-CREATION > lens-ui/config.json PRE-CREATION > lens-ui/index.html PRE-CREATION > lens-ui/package.json PRE-CREATION > lens-ui/server.js PRE-CREATION > lens-ui/webpack.config.js PRE-CREATION > > Diff: https://reviews.apache.org/r/37530/diff/ > > > Testing > ------- > > No server code added/modified. Just JavaScript! > > > Thanks, > > Ankeet Maini > >
