Josias Thoeny wrote:
On Mon, 2006-01-30 at 14:30 +0100, Felix Röthenbacher wrote:
Hi Josias
Josias Thoeny wrote:
Hi,
I would like to remove the DocumentURLModule and the ProxyURLModule from
the trunk, and integrate this functionality into the DocumentInfoModule,
in order to have a consistent way of accessing document related
information.
Any concerns? Or may I do that?
I have some concerns but maybe you can clarify this. My personal opinion
is to keep the document info module separate from any URL handling as
this should be done by some navigation framework. There might be
different implementations for this, solely based on the document id.
I would propose to unify both the DocumentURLModule and ProxyURLModule,
but keep the DocumentInfoModule free from any URL handling.
WDYT?
Currently the URL of a document is retrieved via some getURL() methods
of the Document class, ....
Which IMHO is bad design as the document shouldn't know anything about
its accessibility from the outside world, say its URL. I think it's very
important to stick to well-defined interfaces (API) that respect the
separation of concerns (SoC).
... so it makes sense to get the URL from the
doc-info module.
-1
But if we want to have multiple navigations, and if we introduce the new
repo interfaces, the situation may change.
Maybe the document won't have a getURL() method anymore, and the URL
will be created by a separate component. In this case you are right and
the URL should probably be handled by a separate input module also.
However, it is quite unclear to me how such a navigation framework would
look like, so I don't know how to write the input modules either.
Maybe we should discuss this topic first. Anybody any ideas?
- Felix
Josias
- Felix
thanks,
Josias
--
Felix Röthenbacher [EMAIL PROTECTED]
Wyona Inc. - Open Source Content Management - Apache Lenya
http://www.wyona.com http://lenya.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
