Thorsten Scherler wrote:
El jue, 06-04-2006 a las 17:28 +0200, Andreas Hartmann escribió:
Hi Lenya devs,
do we still need the RevisionController related actions?
- DiscoverCheckoutAction
- ReservedCheck*Action
- RevisionControllerAction
IIUC they violate the principle that actions should have
no side effects.
Apart from this, I'd suggest to move away from actions anyway
due to their ambiguous nature and instead use
- selectors to control sitemap flow
- the usecase framework for user interaction
Any objections to removing them?
not from me.
I assume Andreas has set "Lazy approval", so if nobody is casting -1 he
will go ahead and do it.
http://forrest.apache.org/guidelines.html#approvals
Thanks for the pointer :)
I'll wait some more days and then search the codebase for
references to these actions and remove them if I won't
find any. Dead code should be removed, especially if it
violates our design.
-- Andreas
--
Andreas Hartmann
Wyona Inc. - Open Source Content Management - Apache Lenya
http://www.wyona.com http://lenya.apache.org
[EMAIL PROTECTED] [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
