Joern Nettingsmeier wrote:
[EMAIL PROTECTED] wrote:
Author: andreas
Date: Thu Jun 8 03:45:46 2006
New Revision: 412718
URL: http://svn.apache.org/viewvc?rev=412718&view=rev
Log:
Added check for document existence to module menus to avoid exception for
non-existing documents in the site area.
Modified:
lenya/trunk/src/modules/cforms/config/menu.xsp
lenya/trunk/src/modules/links/config/menu.xsp
lenya/trunk/src/modules/opendocument/config/menus/opendocument.xsp
lenya/trunk/src/modules/xhtml/config/menu.xsp
lenya/trunk/src/pubs/default/modules/homepage/config/menus/homepage.xsp
this is a lot of code duplication.
Yes, I don't like it either :(
isn't there a way to move this
snippet into an xsp "functions" file, maybe via cinclude and friends?
Hmmm, I wouldn't like to add any indirections / includes to XSP unless
this is absolutely necessary. Maybe we can optimize the input module(s)
to require less checking code in the menu XSP?
BTW, good to see that you're a critical commit list reader :)
-- Andreas
--
Andreas Hartmann
Wyona Inc. - Open Source Content Management - Apache Lenya
http://www.wyona.com http://lenya.apache.org
[EMAIL PROTECTED] [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]