Joern Nettingsmeier schrieb:
> Andreas Hartmann wrote:

[...]

>> They are implementation
>> details, therefore the PublicationConfiguration is not part of the
>> Lenya API. You can't compile anything which accesses this class.
>> This protects you from losing binary backwards compatibility when the
>> syntax of publication.xconf changes.
>>
>> If you want to configure a publication, this should be done using the
>> Lenya API. But ATM we don't provide these configuration options
>> (i.e., there are no corresponding setters in the Publication interface).
>>
>> There are two options:
>>
>> 1) add these setters now and everything which that implies
>>
>> 2) leave the duplicated strings in the Instantiator until
>>    we have these setters
> 
> should these setters go into Publication or rather
> PublicationConfiguration? anyways, looks like post-1.4 stuff.

They should be added to the Publication interface, the
PublicationConfiguration is just a back-end for processing XML.

> for now, i wonder whether it would be the lesser evil to make the string
> constants in PublicationConfiguration public? like "if you want to screw
> around on my turf, at least have the manners to do it my way...".

It won't help to make them public, since the PublicationConfiguration
is in src/impl, which is hidden from all client code.

-- Andreas


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to