Michael Wechner wrote:
Jörn Nettingsmeier wrote:
hi everyone!
src/webapp/lenya/bin/ contains some sftp control files and unix
shellscripts. they don't seem to be very generic, so i guess they are
probably not useful for anybody anymore...
copy-recursive.sh
this seems to be a very convoluted way of doing scp -r...
replicate.sh
a script to batch-copy a tomcat-deployed publication?
sftp-copy-children.txt
sftp-copy-index.txt
sftp-mkdir-children.txt
sftp command batch files, not generic
sftp.sh
a wrapper for sftp -b :o)
tomcatctrl
a system-v style init script for tomcat. should come with all sane
distros nowadays.
I think these utilities are very useful at least when using Lenya within
a productive environment.
the problem is that it's not clear to anyone but the author what exactly
they are useful for, and it seems that at least the sftp stuff is
needlessly complicated (it really doesn't seem to do much more than a
recursive copy, which can easily be done with scp -r). all in all, the
scripts look like somebody's very personal toolkit...
one other thing i do not understand is why these scripts are deployed to
the webapp... sounds like a really bad idea to me.
another thing worth considering is the fact that we aim to be
cross-platform. that means it does not make much sense to keep unix
scripts around when there's no windows equivalent.
it's not clear whether this stuff is really up-to-date and still
working. if you can do some tests and add a few comments that explain
what it's all about and will make the code useful for everybody, i'm all
for keeping it. but i'd rather not keep untested code in the trunk that
has fallen into disuse and does not get regular testing.
if nobody has any objections, i'll remove the entire bin directory
from the core. if people do see a need to haul small utility scripts
around, we should create a new directory like "util" directly below
trunk/, but i don't see why we should have them in the core tree.
moving them out of the core makes sense, but I am -1 on deleting them.
ok. for now i'll be moving it into a trunk/utils directory and remove
them from the deployment targets, but the stuff stays on my list unless
users of that code speak up and review and comment it a little within
the next 2 weeks or so.
chim-chiminey, chim-chiminey, chim chim cheree
a sweep is as lucky as lucky can be. :-D
jörn
--
Jörn Nettingsmeier
Kurt is up in heaven now.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
