Richard Frovarp wrote:
Joern Nettingsmeier wrote:
Richard Frovarp wrote:
I've got a couple of additions to clean-xhtml.xsl that I wanted to
see what others thought.
where is that one used again? post-editing? is that a global or
fckeditor-specific file?
Post editing. And it is a global file:
src/modules/xhtml/xslt/clean-xhtml.xsl
1) Make sure the title element is not empty. This will cause problems
when trying to edit pages with IE, as the element will collapse. If
it is empty, insert the text Title.
yeah, we need a couple of those. empty textareas, scripts and divs
confuse firefox... shouldn't we add   rather than "Title"? we
don't want those placeholders to end up in published pages...
If we have the need for more place holders, that might make sense. I
think I've ran into problems, however. Sticking   into empty divs
could cause problems. I'll have to check it out. The title element from
the content file isn't used to generate the real page title, at least
not following the default publication system.
ah, ok. that is moot, then.
2) Strip out the spellcheck="false" attribute from the body tag that
FCKeditor sticks in to turn off Firefox's spell checking feature.
if you're talking about an fckeditor-specific clean-xhtml.xsl, that's
fine. if it's global, i'd rather we do editor-specific cleanups in the
respective modules...
Looks like I already got someone to apply this one. The file already
imports kupu and bxe specific files. It also converts img tags to object
tags, which FCK doesn't like. From what I can see at the moment, Kupu
and BXE don't have their own editor-specific cleanup file either, just
their own import files. In fact the Kupu one has duplication from the
main file. I don't see anything preventing either one from being ran
when that specific editor isn't being used. I'm not sure what it would
take to change is so each editor would only use their specific file.
well, then just put the fck stuff there, too. but we should make a huge
mental note that each editor module should do their own pre-processing
and cleanup in the future...
--
jörn nettingsmeier
home://germany/45128 essen/lortzingstr. 11/
http://spunk.dnsalias.org
phone://+49/201/491621
Kurt is up in Heaven now.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
