[
https://issues.apache.org/jira/browse/LIBCLOUD-249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13495046#comment-13495046
]
Tomaz Muraus commented on LIBCLOUD-249:
---------------------------------------
Patch looks good in general. Here are a couple of more things I have noticed:
1. I renamed 'ttl_sec' to 'ttl' because all of the other drivers use 'ttl'
3. Why do you pre-populate 'extra' dictionary with 'soa' and 'ns' attributes
when creating a zone?
3. Tests look good, but there are no tests for all the different edge cases.
Thanks
> This patch adds support for HostVirtual API http://www.vr.org/ (compute and
> dns driver)
> ---------------------------------------------------------------------------------------
>
> Key: LIBCLOUD-249
> URL: https://issues.apache.org/jira/browse/LIBCLOUD-249
> Project: Libcloud
> Issue Type: New Feature
> Components: Compute, Core, DNS
> Reporter: Dinesh Bhoopathy
> Assignee: Tomaz Muraus
> Labels: compute, dns, patch
> Attachments: hostvirtual-compute-driver.patch,
> hostvirtual-dns-driver.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
