[
https://issues.apache.org/jira/browse/LIBCLOUD-253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13526208#comment-13526208
]
Tomaz Muraus commented on LIBCLOUD-253:
---------------------------------------
First thanks for the patch again. I just reviewed it and noticed some issues:
* there are no tests - one of the requirements for the patch being merged is
presence of good test cases
* variable = type() variable = some_value - this syntax is just weird, there is
no need to do this in Python (I assume you wanted to declare a variable type or
something)
* if type(security_group) == OpenStackSecurityGroup - I think we should only
support one way of passing in a group - either by passing in a string or
instance of OpenStackSecurityGroup
> Add support for security groups in OpenStack driver
> ---------------------------------------------------
>
> Key: LIBCLOUD-253
> URL: https://issues.apache.org/jira/browse/LIBCLOUD-253
> Project: Libcloud
> Issue Type: Improvement
> Components: Compute
> Reporter: L. Schaub
> Labels: OpenStack, features, patch, security_groups
> Attachments: libcloud-openstack-security-groups.patch
>
> Original Estimate: 168h
> Remaining Estimate: 168h
>
> Add parameter ex_security_groups in create_node method.
> Add ex_list_security_groups and ex_get_node_security_groups methods.
> Add ex_create_security_group and ex_delete_security_group methods
> Add ex_create_security_group_rule and ex_delete_security_group_rule methods
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
