[ 
https://issues.apache.org/jira/browse/LIBCLOUD-280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13545607#comment-13545607
 ] 

Marcin Kuzminski commented on LIBCLOUD-280:
-------------------------------------------

I seen the patch, i think it should be patched in both Base and child classes:

diff --git a/libcloud/compute/drivers/ec2.py b/libcloud/compute/drivers/ec2.py
index 
bac0fedd20d53c3fdaa9dbc59f3abee677a10fac..c1af435a297fe7322b523f07bd4f1d39ff42ca5e
 100644
--- a/libcloud/compute/drivers/ec2.py
+++ b/libcloud/compute/drivers/ec2.py
@@ -457,7 +457,7 @@ class BaseEC2NodeDriver(NodeDriver):
     NODE_STATE_MAP = {
         'pending': NodeState.PENDING,
         'running': NodeState.RUNNING,
-        'shutting-down': NodeState.TERMINATED,
+        'shutting-down': NodeState.UNKNOWN,
         'terminated': NodeState.TERMINATED
     }
 
@@ -1405,7 +1405,7 @@ class EC2NodeDriver(BaseEC2NodeDriver):
     NODE_STATE_MAP = {
         'pending': NodeState.PENDING,
         'running': NodeState.RUNNING,
-        'shutting-down': NodeState.TERMINATED,
+        'shutting-down': NodeState.UNKNOWN,
         'terminated': NodeState.TERMINATED
     }
                
> EC2 node state 'shutting-down' is mapped to TERMINATED state
> ------------------------------------------------------------
>
>                 Key: LIBCLOUD-280
>                 URL: https://issues.apache.org/jira/browse/LIBCLOUD-280
>             Project: Libcloud
>          Issue Type: Bug
>          Components: Compute
>            Reporter: Marcin Kuzminski
>              Labels: backward-incompatible
>
> Ec2 node map translates shutting-down state to TERMINATED, IMHO it's a bug. 
> When you want to terminated instances, and then for example delete security 
> group for those node you have to do it after nodes are actually terminated. 
> Current code makes the instances that are being terminated indicated as 
> already terminated. I think the mapping should be 'shutting-down': 
> NodeState.UNKNOWN, as sen in other drivers for example in brightbox

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to