[
https://issues.apache.org/jira/browse/LIBCLOUD-282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tomaz Muraus resolved LIBCLOUD-282.
-----------------------------------
Resolution: Fixed
Assignee: Tomaz Muraus
I've added a test case and merged your patch into trunk -
http://svn.apache.org/viewvc?view=revision&revision=r1438350. Thanks.
No or little tests for other 'ex_' arguments and methods is not a good argument
for not adding tests for the new functionality. It was mostly us being sloppy
and not enforcing "tests for everything" rule well enough. One of the most
important things besides good code reviews which helps to keep the code quality
high and prevents regressions are tests.
> add support to EC2 NodeDriver for passing Block Device Mappings (for
> ephemeral instance storage)
> ------------------------------------------------------------------------------------------------
>
> Key: LIBCLOUD-282
> URL: https://issues.apache.org/jira/browse/LIBCLOUD-282
> Project: Libcloud
> Issue Type: Improvement
> Components: Compute
> Affects Versions: 0.11.2
> Reporter: joe miller
> Assignee: Tomaz Muraus
> Labels: patch
> Attachments: ec2_block_dev_mappings_0.12.0.patch
>
>
> When creating an EC2 node that utilizes EBS-backed root storage the ephemeral
> instance storage disks are not available unless explicitly requested by
> including BlockDeviceMappings in the call to RunInstances.
> This patch adds support for passing an array of BlockDeviceMappings to the
> EC2NodeDriver's create_node() function using the ex_blockdevicemappings kwarg.
> Example:
> ```
> ec2_ephemeral_mappings = [{'DeviceName': '/dev/sdb', 'VirtualName':
> 'ephemeral0'},
> {'DeviceName': '/dev/sdc', 'VirtualName':
> 'ephemeral1'},
> {'DeviceName': '/dev/sdd', 'VirtualName':
> 'ephemeral2'}]
> ec2.create_node(name=name, image=image, size=size,
> ex_blockdevicemappings=ec2_ephemeral_mappings)
> [{'DeviceName': '/dev/sdb', 'VirtualName': 'ephemeral0'}]
> ```
> also on github, branch:
> https://github.com/pantheon-systems/libcloud/tree/ec2_block_dev_mappings
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
