[ 
https://issues.apache.org/jira/browse/LIBCLOUD-291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tomaz Muraus resolved LIBCLOUD-291.
-----------------------------------

    Resolution: Fixed
      Assignee: Tomaz Muraus

Thanks. I've merged your patch into trunk with some fixes.

After applying your patch the IBM SCE tests failed. There were two issues:

- mixing tabs and spaces
- invalid name of the mock http method for returning destroy_image.xml response

======================================================================
ERROR: test_ex_destroy_image (libcloud.test.compute.test_ibm_sce.IBMTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/w/lc/trunk/libcloud/test/compute/test_ibm_sce.py", line 194, in 
test_ex_destroy_image
    ret = self.driver.ex_destroy_image(image[0])
  File "/w/lc/trunk/libcloud/compute/drivers/ibm_sce.py", line 361, in 
ex_destroy_image
    method='DELETE').status)
  File "/w/lc/trunk/libcloud/common/base.py", line 600, in request
    headers=headers)
  File "/w/lc/trunk/libcloud/test/__init__.py", line 172, in request
    meth = getattr(self, meth_name.replace('%', '_'))
AttributeError: 'IBMMockHttp' object has no attribute 
'_computecloud_enterprise_api_rest_20100331_offerings_image_2_DESTROY'

Next time before submitting a patch please make sure the tests pass.
                
> Deletion of an image for IBM sce driver
> ---------------------------------------
>
>                 Key: LIBCLOUD-291
>                 URL: https://issues.apache.org/jira/browse/LIBCLOUD-291
>             Project: Libcloud
>          Issue Type: Task
>          Components: Compute, Libcloud REST
>    Affects Versions: 0.11.2
>            Reporter: Perry Zou
>            Assignee: Tomaz Muraus
>             Fix For: 0.11.2
>
>         Attachments: ibm_sbc_destroy_image.patch
>
>
> Delete image is the functionality provided by IBM SCE. The patch is to 
> provide image deletion feature for IBM SCE.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to