[ 
https://issues.apache.org/jira/browse/LIBCLOUD-295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tomaz Muraus resolved LIBCLOUD-295.
-----------------------------------

    Resolution: Fixed

Thanks for the patch. I've made the following changes and merged it into trunk:

- pep8 style fixes
- Changed variable name from "ids" to "size_id". Having a plural name for a 
variable which isn't a collection is deceiving and confusing.
- Refactored _to_sizes to reduce amount of repeated code.
- Improved assertions in the test - doing a loosely assertion like 
"self.assertTrue(size.cpu is None or isinstance(size.cpu, float))" is 
unnecessary and doesn't make sense. Tests use fixtures so the order in which 
sizes are returned is deterministic.

Next time please also follow the contribution guidelines described at 
http://libcloud.apache.org/contributing.html. You submitted a git formatted 
patch which can't be applied directly to a SVN tree so this means more work for 
us.
                
> Opennebula 3.8 support
> ----------------------
>
>                 Key: LIBCLOUD-295
>                 URL: https://issues.apache.org/jira/browse/LIBCLOUD-295
>             Project: Libcloud
>          Issue Type: Improvement
>          Components: Compute
>            Reporter: Guillaume ZITTA
>              Labels: features, newbie, patch
>         Attachments: patch_LIBCLOUD-295.patch
>
>
> between Opennebula 3.2 and 3.8, at least 2 things changed :
> - size listing need sub-requests
>   information is no longer available on /instance_type hit
>   it is needed to iterate over /instance_type/$N
> - plain auth
>   possibility to use non sha1 auth header for incompatible reverse-proxy

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to