[ 
https://issues.apache.org/jira/browse/LIBCLOUD-323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13645984#comment-13645984
 ] 

Tomaz Muraus commented on LIBCLOUD-323:
---------------------------------------

Thanks.

The patch looks good, but I would really like to see some tests for those 
changes. Let us know if you need help with writing them.
                
> Make vCloud driver more robust
> ------------------------------
>
>                 Key: LIBCLOUD-323
>                 URL: https://issues.apache.org/jira/browse/LIBCLOUD-323
>             Project: Libcloud
>          Issue Type: Bug
>          Components: Compute
>    Affects Versions: 0.12.3
>            Reporter: Michel Samia
>            Priority: Minor
>         Attachments: LIBCLOUD-vcloud_minor_patches.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> There are several small and easy-to-fix problems in VCloud driver:
> # _validate_vm_names(): now there is a specialized list of acceptable Virtual 
> memory sizes for vCloud 1.5, but it seems that these values don't work in 
> version 1.5. The old values from vCloud 0.8 work well
> # ex_list_nodes(): because node listing has two phases (in first phase we 
> send request for getting URLs of all the VMs and in the second we send one 
> request per VM for getting all info about the VM), there can happen a 
> situation where some VM is deleted between these two phases. Then we want to 
> ignore this VM and we don't want to report any error (=raise an exception). 
> The existing checker of this situation is too generic and can silence any 
> other exception satisfying some other conditions
> # VCloud_1_5_NodeDriver._to_node(): the OS XML element is not required, so 
> when not present, we cannot get its attributes
> We have fixed all these three problems in the patch attached below

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to