[ 
https://issues.apache.org/jira/browse/LIBCLOUD-249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13652749#comment-13652749
 ] 

Tomaz Muraus commented on LIBCLOUD-249:
---------------------------------------

Thanks. There were some issues (style, missing doc string, failing test, etc.) 
which I've fixed and merged your patch into trunk and 0.12.x.

kami /w/lc/t1 (svn)$ PYTHONPATH=. python 
libcloud/test/compute/test_hostvirtual.py
...E..........
======================================================================
ERROR: test_ex_build_node (__main__.HostVirtualTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "libcloud/test/compute/test_hostvirtual.py", line 120, in 
test_ex_build_node
    self.assertTrue(self.driver.ex_build_node(
AttributeError: 'HostVirtualNodeDriver' object has no attribute 'ex_build_node'

----------------------------------------------------------------------
Ran 14 tests in 0.008s


Next time please make sure you add the docstrings and make sure tests are 
passing before submitting a patch. 
                
> This patch adds support for HostVirtual API http://www.vr.org/ (compute and 
> dns driver)
> ---------------------------------------------------------------------------------------
>
>                 Key: LIBCLOUD-249
>                 URL: https://issues.apache.org/jira/browse/LIBCLOUD-249
>             Project: Libcloud
>          Issue Type: New Feature
>          Components: Compute, Core, DNS
>            Reporter: Dinesh Bhoopathy
>            Assignee: Tomaz Muraus
>              Labels: compute, dns, patch
>             Fix For: 0.12.1
>
>         Attachments: apifix.patch, compute.patch, withdocstrings.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to