[
https://issues.apache.org/jira/browse/LIBCLOUD-349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13691788#comment-13691788
]
Tomaz Muraus commented on LIBCLOUD-349:
---------------------------------------
Otherwise the patch looks good, but the tests can be improved.
Tests in the current form do increase the pure code coverage numbers, but
that's about it. As far as testing stuff goes, they don't actually test /
verify a lot though.
Instead of doing those type checks it would be better to check, for example,
that a single NodeImage instance contains the right attributes. Same goes for
the networks.
For example:
{code}
images = self.driver.list_images()
self.assertEqual(images[0].name, 'foo')
....
{code}
Thanks
> no tests for list_networks and list_templates in cloudstack driver
> ------------------------------------------------------------------
>
> Key: LIBCLOUD-349
> URL: https://issues.apache.org/jira/browse/LIBCLOUD-349
> Project: Libcloud
> Issue Type: Bug
> Components: Compute
> Affects Versions: 0.12.3
> Reporter: sebastien goasguen
> Fix For: 0.12.3
>
> Attachments: list_images.patch, list_networks.patch
>
>
> no tests in test_cloudstack.py for list_networks and list_templates, even
> though the fixtures are there
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
