I have been thinking more about the import_* methods.

I kinda like the "create_keypair_from_public_key" idea, but the problem is
that we have two variants of this method (one which takes a file path and
one which takes key material) which means we would need to suffix it with
"_from_string" and "_from_file".

This would make method names long and kinda weird.

I really think existing name is deceiving (you are importing just a public
key and not a pair of private + public key), but EC2 API method name is
"ImportKeyPair" so maybe we should stick to it and other users won't find
this as a problem.

As far as the "key_pair" and "keypair" goes. I've done some more research
and and came and here are the results:

* OpenStack and CloudStack documentation mostly refers to it using a single
word
* CloudStack API method consists of two words (camelCase, SSHKeyPairs)
* EC2 refers to it using two words everywhere, including the API method name

Because of that I'm kinda leaning towards consistency and two words
(key_pair).

I have also updated gist to include create_node definition and reflect the
latest state.

On Thu, Dec 5, 2013 at 9:18 PM, John Carr <[email protected]> wrote:

> create_keypair_from_public_key
>

Reply via email to