The bugs are fixed in the PR #610. The driver has 96% test coverage, but the tests are checking the logic of the functions that they make a request to the correct URL, then a mock HTTP provider has XML responses from the API and it checks that the methods are reading and processing the responses.
What they don't check is that the request to the API not only meets the correct URL but that the request message is formatted correctly. I can update the tests so they check the XML element names, but not match the entire payload because the tests will be too fragile. I can do this tomorrow. Ant On Tue, Oct 20, 2015 at 9:29 AM, Eric Johnson <[email protected]> wrote: > Anthony, do you think you can get tests added in the next few days? Bugs > are bad and I'm happy to abandon this vote thread if we can get test > coverage in place too. > > > > On Mon, Oct 19, 2015 at 3:23 PM, anthony shaw <[email protected]> > wrote: > > > np, they were 2 new functions so it doesn't affect existing > functionality. > > It can be a known issue with the driver for 19.0. > > > > I need to extend the unit tests to check the request payloads as well as > > the response payloads in future. > > > > Ant > > > > On Tue, Oct 20, 2015 at 9:01 AM, Tomaz Muraus <[email protected]> wrote: > > > > > I'll talk to Eric about closing this voting thread and spinning up a > new > > > one with this fix. > > > > > > An alternative is continuing with this release and spinning up 0.19.1 > > with > > > this fix immediately once 0.19.0 is out... > > > > > > On Mon, Oct 19, 2015 at 11:40 PM, anthony shaw < > [email protected] > > > > > > wrote: > > > > > > > @EfrenRey spotted a bug in the Dimension data driver, which is fixed > in > > > PR > > > > #610 https://github.com/apache/libcloud/pull/610 > > > > > > > > It would be great if that could be merged and added to the tag! Sorry > > for > > > > the last minute, just got onto it yesterday. > > > > > > > > Ant > > > > > > > > On Tue, Oct 20, 2015 at 5:45 AM, Tomaz Muraus <[email protected]> > > wrote: > > > > > > > > > Checked and tested the release artifacts. > > > > > > > > > > Looks good to me. > > > > > > > > > > [+1] Release Apache Libcloud 0.19.0 > > > > > > > > > > On Mon, Oct 19, 2015 at 7:16 PM, Eric Johnson <[email protected] > > > > > > wrote: > > > > > > > > > > > This is a voting thread for Libcloud 0.19.0. > > > > > > > > > > > > This release contains numerous new features, improvements and bug > > > > fixes. > > > > > > The full change log can be found at > > > > > > > > > > > > > > > > > > > > > > > > > > > https://git-wip-us.apache.org/repos/asf?p=libcloud.git;a=blob;f=CHANGES.rst;h=e1a9b3dd3088797956c4d5b025084df15e3a8bca;hb=fccf348234ed77ac1fad2ae3740506584581d6eb > > > > > > > > > > > > Release artifacts can be found at > > > > > > http://people.apache.org/~erjohnso/libcloud/. > > > > > > > > > > > > Note that KEYS file can found at > > > > > > https://dist.apache.org/repos/dist/release/libcloud/KEYS > > > > > > > > > > > > Please test the release and post your votes. > > > > > > > > > > > > +/- 1 > > > > > > [ ] Release Apache Libcloud 0.19.0 > > > > > > > > > > > > Vote will be open until October 23rd, 2015 (or longer, if > needed). > > > > > > > > > > > > Thanks, > > > > > > Eric > > > > > > > > > > > > > > > > > > > > >
