assapin commented on a change in pull request #1:
URL: https://github.com/apache/incubator-liminal/pull/1#discussion_r525510382
##########
File path: scripts/liminal
##########
@@ -84,9 +84,14 @@ def deploy_liminal_core_internal(clean):
def docker_compose_command(command_name, args):
docker_compose_path, project_dir = get_docker_compose_paths()
concated_args = ' '.join(args)
- subprocess.call(
+ if 'follow' in str(args):
+ subprocess.call(
+ [f'docker-compose -f "{docker_compose_path}" -p liminal
--project-directory {project_dir} {command_name} {concated_args}'],
+ env=os.environ, shell=True)
+ output = subprocess.run(
Review comment:
better to prepare the command string once, and decide if to invoke it
with subprocess.call or run.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
