peacewong commented on a change in pull request #1174:
URL: https://github.com/apache/incubator-linkis/pull/1174#discussion_r765769413
##########
File path:
linkis-computation-governance/linkis-manager/linkis-application-manager/src/main/scala/org/apache/linkis/manager/am/selector/rule/AvailableNodeSelectRule.scala
##########
@@ -34,13 +34,15 @@ class AvailableNodeSelectRule extends NodeSelectRule with
Logging{
if (null != nodes) {
nodes.filter {
case amNode: AMNode =>
- if (! NodeStatus.isLocked(amNode.getNodeStatus) &&
NodeStatus.isAvailable(amNode.getNodeStatus) ) {
+ if (!NodeStatus.isLocked(amNode.getNodeStatus)
+ && NodeStatus.isAvailable(amNode.getNodeStatus)
+ &&
NodeStatus.isEngineNodeHealthy(amNode.getNodeStatus).equals(NodeHealthy.Healthy))
{
Review comment:
Hello, nodeHealthy should be used for judgment here, and status cannot
be used to judge nodeHealthy
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
