Hello Sebastien, I have answered your comments in all reviews a few days ago, can you please have a look at them?
Most of them seems to be minor things probably not even issues. Or I would need some more reasoning or kick off to know how to "fix" them :-) I am a little bit more busy these weeks so I may be slower with responding and addressing the comments. Thank you, Filip On 2015/08/08 14:06, Sebastien Badia wrote: > On Tue, Aug 04, 2015 at 08:04:36PM (+0200), Sebastien Badia wrote: > > Sorry, I come lately in the « battle », many thanks Filip for your work, and > > especially the effort to push this work upstream!! > > […] > > https://review.opencontrail.org/#/c/12573/ > > […] > > > And for nodemgr why we don't use install target and > > [PYTHON_]INSTALL_{BIN,CONF} > > of scons build ? > > OK… the comments on https://review.opencontrail.org/#/c/12573/ wasn't > addressed and even > not replied/discussed. This is really pointless to make review… > > And the backport to 2.20 https://review.opencontrail.org/#/c/12921/ was merged > without the original SHA (git cherry-pick -x <sha>). > > Seb > > -- > Sebastien Badia > _______________________________________________ > Dev mailing list > [email protected] > http://lists.opencontrail.org/mailman/listinfo/dev_lists.opencontrail.org
signature.asc
Description: Digital signature
_______________________________________________ Dev mailing list [email protected] http://lists.opencontrail.org/mailman/listinfo/dev_lists.opencontrail.org
