On Wed, May 17, 2017 at 11:18:49AM +0500, Valentine Sinitsyn wrote: > Hi Ananth, > > On 17.05.2017 11:00, Ananth Suryanarayana wrote: > >Hi, > > > >On Wed, May 17, 2017 at 10:50:38AM +0500, Valentine Sinitsyn wrote: > >>Hi, > >> > >>Those are valid points. I'd add a few more, if you don't mind: > >> > >>1. Code quality (esp. in master branch) > >>I've encountered undefined macros in vrouter-dpdk and shell escaping issues > >>in dkms scripts at the very least. Sure, this is trivial to fix, yet it > >>makes me think that either no one tried to compile those components besides > >>me (as this fails immediately) or I do something awfully wrong. Which brings > >>us to the second point: > >> > >>2. Public CI, maybe via Travis/Github badge > >>This is to make sure the code works at least in some environment, so I can > >>figure out what's wrong with mine. Aside issues mentioned above, BGP stress > >>test is failing now as well, and there is no way to figure out is it my > >>fault or the thing is currently broken. > >I can certainly help out with bgp_stress_test failure. It is part of our > >regular CI and is run for every commit applicable. May be it is not working > >under some specific set of parameters that you are using with ? May I request > >for more details regarding this ? > Thank you for the help. Above, I've used BGP stress test mainly to > illustrate my points, yet it of course would be good to fix this particular > issue as well. I tried it some time ago; will do it again and come back with > results and details to you shortly.
Thanks. I look forward to hearing from you. Regards Ananth _______________________________________________ Dev mailing list [email protected] http://lists.opencontrail.org/mailman/listinfo/dev_lists.opencontrail.org
