On Mon, Jul 25, 2016 at 2:22 PM, Andy Goldstein <[email protected]> wrote:
> > > On Mon, Jul 25, 2016 at 2:15 PM, Clayton Coleman <[email protected]> > wrote: > >> Protobuf support has been merged to origin, which has an impact on dev >> workflows. >> >> If you are changing the API, you'll need to run >> >> hack/update-generated-protobuf.sh >> >> to generate the IDL for your changes, and those changes will be checked >> in. >> > > When can we remove generated code from the repo and have it excluded via > .gitignore and build locally when needed? > Not until 1.4 or later. As upstream has demonstrated, a bunch of problems had to be solved. > > >> You need protoc 3.0.0-beta1 or newer installed. A verification step is >> run during the integration suite (because it requires docker and we call >> verify on travis today). >> >> For more information about protobuf and how it's used, read here: >> >> * https://groups.google.com/d/topic/kubernetes-dev/8ZkGd_TvzFQ/discussion >> * // >> github.com/kubernetes/kubernetes/blob/master/docs/devel/api_changes.md#generate-protobuf-objects >> >> If you don't have protoc installed, you can use the `hack/env` script to >> run generation and verification inside of a docker container: >> >> hack/env hack/verify-generated-protobuf.sh >> >> will take your committed source code and run the verify step inside of a >> container. If you want to run updates, you can do the following: >> >> OS_BUILD_ENV_LEAVE_CONTAINER=1 hack/env >> hack/update-generated-protubuf.sh >> docker cp <container_id>:/go/src/github.com/openshift/origin/pkg >> ./pkg >> >> which will copy those out. >> >> _______________________________________________ >> dev mailing list >> [email protected] >> http://lists.openshift.redhat.com/openshiftmm/listinfo/dev >> >> >
_______________________________________________ dev mailing list [email protected] http://lists.openshift.redhat.com/openshiftmm/listinfo/dev
