On Tue, 11 Jun 2024 23:17:52 -0400 bill-auger <[email protected]> wrote:
> there are a few problems with this one - most significantly, you did > not update the pkgver or the pkgrel - the repo would not accept that > package because it has the identical filename as the existing one - > at the very least, the pkgrel needs to be bumped - but it is not > obvious what pkgver represents - we probably discussed this before > but i forgot - was this intended to be the date of the VCS commit? - > if so, the pkgver should have changed instead - so im not sure how to > proceed > > i tried to get that date myself; but when i went to the upstream VCS > website, i could not find _upstream_rev=5922 anywhere - where does > that number come from? - how would i known which date > _upstream_rev=5922 was committed? > > https://hg.prosody.im/prosody-modules/shortlog/tip > > maybe the source should use the IDs shown on that website instead, > such as today's tip 'f408b8e603af' - would that work? > > _upstream_rev=f408b8e603af > > mksource=(${pkgname}-${pkgver}::hg+https://hg.prosody.im/prosody-modules/#revision=${_upstream_rev}) > > one less important thing, i reverted this change: > > -# Copyright (C) 2022 Wael Karram <[email protected]> > +# Copyright (C) 2024 Wael Karram <[email protected]> > > im still on the fence about those copyright lines - the reason we > started putting 'SPDX-License-Identifier: CC0' is because really, no > one believes that these recipes are copyrightable - on that > presumption, the only significant change that you made to this file > in 2024 is not copyrightable by any measure > > -_upstream_rev=5579 > +_upstream_rev=5922 > > if any of that PKGBUILD is copyrightable, it would be the initial > complete version - most likely, this package will never receive any > copyrightable changes after the initial publishing - so i think in > these cases, the original year when the PKGBUILD was written can > remain, unless some truly significant change is made - that will > never happen for most PKGBUILDs > > also, the year in the copyright line is supposed to identify all > years in which significant changes were made - so if this year's > changes were significant, then so would be the changes in 2023 - in > that case the copyright line would be 2022-2024 > _______________________________________________ > Dev mailing list > [email protected] > https://lists.parabola.nu/mailman/listinfo/dev Thanks a lot for pointing these issues out, I've fixed it, and tested it to compile (though with my key, not yours) - I've attached the updated file and patch. -- Kind Regards, Wael Karram.
From 0decbaf11816f7288a0209908348b2e1417670f1 Mon Sep 17 00:00:00 2001 From: wael <[email protected]> Date: Wed, 12 Jun 2024 09:40:39 +0300 Subject: [PATCH] Fixed the updated pkgbuild for prosody-modules --- pcr/prosody-modules-hg/PKGBUILD | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/pcr/prosody-modules-hg/PKGBUILD b/pcr/prosody-modules-hg/PKGBUILD index 80d5b24f1..f8793385c 100644 --- a/pcr/prosody-modules-hg/PKGBUILD +++ b/pcr/prosody-modules-hg/PKGBUILD @@ -1,4 +1,4 @@ -# Copyright (C) 2024 Wael Karram <[email protected]> +# Copyright (C) 2022 Wael Karram <[email protected]> # SPDX-License-Identifier: CC0-1.0 # Maintainer: Wael Karram <[email protected]> @@ -8,8 +8,9 @@ pkgname=prosody-modules-hg -pkgver=20231108 -_upstream_rev=5922 +pkgver=20240612 +#_upstream_rev=5922 +_upstream_rev=f408b8e603af _prosody_ver=0.12.4 pkgrel=1 pkgdesc="Prosody community modules, includes experimental ones." @@ -21,7 +22,7 @@ makedepends=('mercurial') mksource=(${pkgname}-${pkgver}::hg+https://hg.prosody.im/prosody-modules/#revision=${_upstream_rev}) source=(https://repo.parabola.nu/other/${pkgname}-libre/${pkgname}-libre-${pkgver}.tar.xz{,.sig}) mksha256sums=('SKIP') -sha256sums=('cdcb013ff825dccbdcb5a8ec43493549236b901c7608a7a560e717045d9cb330' 'SKIP') +sha256sums=('22a5de2dced89f592abeaebb7f0f7fde94d364c56a855c988bb6b0a22a22c9d5' 'SKIP') validpgpkeys=('3954A7AB837D0EA9CFA9798925DB7D9B5A8D4B40') # bill-auger -- 2.45.1
PKGBUILD
Description: Binary data
pgpwi_Xnl_dMu.pgp
Description: OpenPGP digital signature
_______________________________________________ Dev mailing list [email protected] https://lists.parabola.nu/mailman/listinfo/dev
