The reason is simple: I couldn't find enough free time for that, and was mostly focused on getting the release out ASAP, due to security fixes. This thing can come later, because it doesn't seem to be active and/or user-facing anyway.
Agreed, removing mobile/ makes sense, but needs some testing, to make sure build doesn't fail. For now I just went over all the grep results and replaced the URL to keep it simple. BTW, regarding 'java' I tend to think the trend is not specific to it. Rather to software ecosystems revolving around a package manager that makes it easy to get packages and their dependencies without thinking what's inside. This IMHO, includes Arch Linux, and, alas, Parabola, because I think too much nonfree stuff leaks unnoticed to the repos nowadays from Arch. On Saturday, June 15th, 2024 at 3:38 AM, bill-auger <[email protected]> wrote: > also, just wondering, why did these 'REMOTE_STAGE_ENDPOINT_URL' not also > get stubbed/spoofed? > > but furthermore, couldnt you simply delete the entire mobile/ directory? - > i would think that the parabola builds would never need nor touch it - > why should you need to patch any of that? - gnuzilla keeps theirs, because > they want people to be able to build the android port - one could argue that > gnuzilla should not; because that use-case requires non-free software - but > gnuzilla is not bound by the FSDG - i think GNU packages can support building > on non-free foreign OSes, in a way tat the FSDG does not allow > > especially anything in proximity to 'java', is probably riddled with junk > > diff --git > a/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/Core.kt > b/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/Core.kt > index 65778d2795..169cc703c8 100644 > --- > a/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/Core.kt > +++ > b/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/Core.kt > @@ -628,7 +628,7 @@ class Core( > > // collection name to fetch from server for SERP telemetry > const val COLLECTION_NAME = "search-telemetry-v2" > - internal const val REMOTE_PROD_ENDPOINT_URL = > "https://firefox.settings.services.mozilla.com"; > + internal const val REMOTE_PROD_ENDPOINT_URL = > "resource://app/defaults/settings" > internal const val REMOTE_STAGE_ENDPOINT_URL = > "https://firefox.settings.services.allizom.org"; > } > } > diff --git > a/mobile/android/focus-android/app/src/main/java/org/mozilla/focus/telemetry/GleanMetricsService.kt > > b/mobile/android/focus-android/app/src/main/java/org/mozilla/focus/telemetry/GleanMetricsService.kt > index 1b6aec961c..695f1f54d3 100644 > --- > a/mobile/android/focus-android/app/src/main/java/org/mozilla/focus/telemetry/GleanMetricsService.kt > +++ > b/mobile/android/focus-android/app/src/main/java/org/mozilla/focus/telemetry/GleanMetricsService.kt > @@ -62,7 +62,7 @@ class GleanMetricsService(context: Context) : > MetricsService { > const val COLLECTION_NAME = "search-telemetry-v2" > > // urls for prod and stage remote settings server > - internal const val REMOTE_PROD_ENDPOINT_URL = > "https://firefox.settings.services.mozilla.com"; > + internal const val REMOTE_PROD_ENDPOINT_URL = > "resource://app/defaults/settings" > internal const val REMOTE_STAGE_ENDPOINT_URL = > "https://firefox.settings.services.allizom.org"; > > private val isEnabledByDefault: Boolean > _______________________________________________ > Dev mailing list > [email protected] > https://lists.parabola.nu/mailman/listinfo/dev _______________________________________________ Dev mailing list [email protected] https://lists.parabola.nu/mailman/listinfo/dev
