Robin Elfrink wrote:
Thomas Bruederli wrote:
Nice work so far!
Thank you!
I still do not like the fact that the core script (app.js) decides
about the size of the preview pane. I'd like to strictly separate the
I agree. But I couldn't get that to work in the timeframe that I needed
the preview pane in.
visual appearance from the core functionality. In your patch the user
can decide whether he/she wants to see the preview pane or not. This
makes it even more complicated to separate functionality and skins.
Complicated maybe, but that's what I need. When I started using
RoundCube for our webmail, some of my users requested a preview pane.
When I got that, some requested that I immediately remove it. It's hard
to please everyone.
(Actually, being a commercially challenged technical person I'd love to
tell half of them to piss off, but that would probably have severe
consequences for my job).
[...]
Either the user can choose from several skins (a nice feature anyway)
That would be nice indeed.
or (that's something I always had in my mind) the template parser can
handle conditional tags like
<roundcube:if condition="$config.preview_pane">
..
<roundcube:else>
..
<roundcube:endif>
That's something I've been thinking about, as well. Is it hard to do? If
you have some pointers for me I can spend some time on this.
Please try out the attached patch on the latest rev. 364 and write
your oppinions about the one or the other approach.
Well, it works. What else can I say. I think I like the fact that the
preview pane is _always_ there, regardless if there's an email being
displayed. Makes it easier for the layout stuff. I don't even remember
why I chose to do it differently.
Robin
I mean not to sound like an ass, so if I do, I apologize. If you want
to include the conditional functionality (<roundcube:if />
<roundcube:else >) then I might suggest looking at what SMARTY has
already put in place. They're dedicated to the template system, and it
works well. I'm not saying convert to SMARTY, but it is an option if
you so choose. But if you wanted to add the functionality, SMARTY
already has it in place and it works very well. So look at how it's
done elsewhere, and bring it over ;)
Just my $0.02
~Brett
