Ah, right. In IE7, correct? If you have tested this with all browsers (IE6/7, firefox and safari), I'd say, commit away.
Maybe send me a link to your diff (trac.roundcube.net) so I can implement it on devel-vnext. Good job! Thanks, Till On 9/15/07, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: > Oh yes, we're using it in production now. Didn't have to change > anything else. > > It should be noted that "Alt" does toggle a menu toolbar in IE 7, so > each time a message is selected, the menus either appear or > disappears. It's less annoying than closing popups at least. > > Rich > > On Sep 14, 2007, at 3:07 PM, till wrote: > > > Did you test it yet? Sure looks like it would get the job done. > > > > Is there anything else you "changed"? > > > > On 9/14/07, Rich at Whidbey Telecom <[EMAIL PROTECTED]> wrote: > >> Although I advise users to switch to Firefox, I worked around the > >> issue > >> by allowing "alt + click" to behave the same as "ctrl + click". > >> > >> To implement it, change line 130 in program/js/common.js from: > >> > >> opcode += (e.ctrlKey && CONTROL_KEY) + (e.shiftKey && SHIFT_KEY); > >> > >> To: > >> > >> opcode += (((e.altKey == true) ? e.altKey : e.ctrlKey) && > >> CONTROL_KEY) + > >> (e.shiftKey && SHIFT_KEY); > >> > >> If this doesn't cause any problems, maybe it should be added to > >> trunk? > >> > >> Rich > >> > >> > >> Thomas Bruederli wrote: > >>> Joel Clermont wrote: > >>>> The biggest problem people moan about is multi-select. It is not > >>>> intuitive to use a key modifier like Shift or Control to select > >>>> multiple > >>>> messages. > >>> > >>> What is not intuitive in this behavior? All apps behave like this. > >>> > >>>> In addition, in IE7 when you control-click it opens the > >>>> message in another tab, so if you control-click 10 messages to > >>>> delete > >>>> them, you now also have 10 tabs to close. > >>> > >>> This is a problem currently not solved because IE7 does not allow > >>> the > >>> javascript to cancel the event. And here we have a conflict > >>> between two > >>> different points of view: some people want to have the message > >>> subject as > >>> real link in order to open the message in a new tab by ctrl- > >>> clicking it and > >>> others want to select multiple messages using ctrl-click. > >>>> Is there something I am missing on this problem? Is there a setting > >>>> where I can enable an old school checkbox column for people to > >>>> use in > >>>> multi-select? > >>> > >>> We don't have checkboxes and there won't be any checkboxes at > >>> all. And > >>> please don't start yet another endless discussion about this! > >>> > >>> The only solution I see is to tell the users that they should not > >>> click the > >>> message subject (but another col or whitespace) when selecting > >>> multiple > >>> messages with ctrl. > >>> > >>> ~Thomas > >>> > >>> > >>> _______________________________________________ > >>> List info: http://lists.roundcube.net/dev/ > >> > >> -- > >> > >> Rich Sandberg > >> [EMAIL PROTECTED] > >> Whidbey Telecom Network Operations > >> _______________________________________________ > >> List info: http://lists.roundcube.net/dev/ > > -- Till Klampaeckel e: mailto:[EMAIL PROTECTED] p: +491704018676 l: http://beta.plazes.com/whereis/till Want to know what's up in Berlin? - http://berlin.metblogs.com _______________________________________________ List info: http://lists.roundcube.net/dev/
