On Fri, Dec 16, 2011 at 11:53 AM, Raoul Bhatia [IPAX] <[email protected]>wrote:
> On 2011-12-12 16:44, Jeroen van Meeuwen (Kolab Systems) wrote: > > On 2011-11-28 10:09, Raoul Bhatia [IPAX] wrote: > >> On 2011-09-23 19:16, Raoul Bhatia [IPAX] wrote: > >>> please review the following patch. > >>> > >>> i find this information very useful and maybe it would be wise to > >>> make > >>> $_SERVER['SERVER_NAME'] the default setting. > >>> (at least, we're doing it for our deployments) > >>> > >>>> --- main.inc.php (revision 2771) > >>>> +++ main.inc.php (working copy) > >>>> @@ -219,7 +219,7 @@ > >>>> // must be greater than 'keep_alive'/60 > >>>> $rcmail_config['session_lifetime'] = 10; > >>>> > >>>> -// session domain: .example.org > >>>> +// session domain: .example.org or $_SERVER['SERVER_NAME'] > >>>> $rcmail_config['session_domain'] = ''; > >>>> > >>>> // Backend to use for session storage. Can either be 'db' > >>>> (default) or 'memcache' > >> > >> anyone? > >> > > > > FWIW, the $_SERVER["SERVER_NAME"] is often not the same as the > > $_SERVER["HTTP_HOST"]. > > indeed. to my knowledge, > HTTP_HOST is set to the "Host:" header sent by the client and > SERVER_NAME is set to the Apache Vhost Name/Alias. > > so to me, SERVER_NAME sounds the right choice. > > in my setup, i have a dedicated webmail vhost with > no ServerAlias for roundcube - so SERVER_NAME seems the most > appropriate value. > > Cheers, > Raoul > +1 for SERVER_NAME as a default. Maybe make it configurable in case people need something else? Till
_______________________________________________ List info: http://lists.roundcube.net/dev/ BT/8f4f07cd
