-- till Sent with Sparrow (http://www.sparrowmailapp.com/?sig)
On Saturday, November 10, 2012 at 8:24 PM, Sébastien BLAISOT wrote: > Le 10/11/2012 19:23, till a écrit : > > On Saturday, November 10, 2012 at 7:19 PM, Sébastien BLAISOT wrote: > > > > > Last question about this particular piece : what happens if the > > > trunk/composer.json contains the same version than, say, > > > tags/1.0.0/composer.json ? should I ensure that in the whole tree no > > > composer.json file has the same version in it than an other > > > composer.json file ? > > > > > > You don't have to take care of anything in this regard. > > The `composer.json` file does not contain any version specific information. > > Once setup, it can be the same — unless your plugin's dependencies change > > over time. > > > > I found on http://getcomposer.org/doc/04-schema.md#version that > composer.json package can/should/must contain version information. > But I see now that it says : "Optional if the package repository can > infer the version from somewhere, such as the VCS tag name in the VCS > repository. In that case it is also recommended to omit it." so I will > remove the version tag from my composer.json Yeah, just to make sure for everyone: What they refer to is the version of your package/plugins dependencies. E.g. * It could be a specific RoundCube version (or minimum version). * Or, let's say you require another library to talk to another web server and require a certain version. * Or a minimum PHP version, etc.. The actual version of your plugin is always based on the branch or tag. :-) Cheers, Till > > > Can you explain in more detail what you're trying to do (or trying to > > avoid)? > > Well, nothing, now that I've read and understood that composer.json > doesn't have to include a version tag ;) > > What I wanted to avoid was having two composer.json files in my > subversion tree having the same version number. > When releasing a new version, when I "svn tag", it leads to having a > file in the trunk with the same version number than in the tag an the > risk to forget about that. > > Nevermind, no more version in composer.json, no more problem. > > regards, > > S.B. > _______________________________________________ > Roundcube Development discussion mailing list > [email protected] (mailto:[email protected]) > http://lists.roundcube.net/mailman/listinfo/dev _______________________________________________ Roundcube Development discussion mailing list [email protected] http://lists.roundcube.net/mailman/listinfo/dev
