On Sunday, November 11, 2012 at 10:15 AM, Martin Wodrich wrote:
> I just updated our Roundcube-Stable Installation from 0.8.2 to 0.8.3 > via ./bin/installto.sh (http://installto.sh) > and found 3 not so good thing in the main.inc.php. > > 1. The Config-Line for the Useragent: > > The old line was: > $rcmail_config['useragent'] = 'Roundcube Webmail/'.RCMAIL_VERSION; > > installto.sh (http://installto.sh) sets it to: > > $rcmail_config['useragent'] = 'Roundcube Webmail/0.8.3'; > > > 2. Config-Lines from plugins that must be configure in the main.inc.php > are lost. Here it is the plugin show_additional_headers and the line > $rcmail_config['show_additional_headers'] = array('Content-Type', > 'Content-Transfer-Encoding', 'User-Agent', 'Mailer', 'X-Mailer', > 'X-Newsreader', 'X-Posting-Agent', 'X-Http-User-Agent', 'X-MimeOLE'); > > > 3. All user defined comments in the config are lost. I am wondering if something like a main.inc.local.php would be a step in the right direction. This would be similar to the host specific configuration files[1], but maybe more straightforward/simple? It would basically be a file which is included (after main.inc.php) and then merged into the config array to override the settings from main.inc.php, etc..? This could be optional — only use it when it's there. With a little APC configuration and/or caching there are next to zero penalties for doing that. If people wanted, we could do this for all configuration files — these files would obviously be off-limit to the installer etc.. main.inc.php > main.inc.local.php > host-specific Food for thoughts! Till [1]: https://github.com/roundcube/roundcubemail/blob/master/program/include/rcube_config.php#L144-L158 _______________________________________________ Roundcube Development discussion mailing list [email protected] http://lists.roundcube.net/mailman/listinfo/dev
