David Deutsch wrote: > First pull request is up: https://github.com/roundcube/roundcubemail/pull/109
Thanks! We'll read through it. > > There were a couple of things that might turn out to be controversial, I > think mostly with calling on the html class - those seem to have a tendency > to get out of hand, so I decided to split it over multiple lines. > > For CSS, I went with a two spaces indent, which seems to be the most > commonly used in the codebase. Let me know if you want four spaces instead. Hmm, we have 4 spaces everywhere else (and in Larry skin we have tabs I suppose). I'd either go for tabs or 4 spaces as well. One more thing: I can already see ourselves in merging hell when we want to merge other pull requests or development branches back into master because most likely a merge attempt will result in conflicts. Any suggestions how that could go smooth? Maybe we should first clean up all of our pending PRs and try to eliminate existing dev branches before the cleanup really gets started. Kind regards, Thomas _______________________________________________ Roundcube Development discussion mailing list [email protected] http://lists.roundcube.net/mailman/listinfo/dev
