David Deutsch wrote:
> Thanks.
>
> And find them I did!
>
> It's just that Thomas said earlier they were the standard in the codebase
> and me changing them would confuse existing developers. So I remain
> unconvinced there is what I'm saying... ;-)
I obviously got your intentions wrong and I'm sorry about this.
We definitely want if ($sky == 'blue') and not if ('blue' == $sky).
~Thomas
>
>
> On Sat, Aug 31, 2013 at 10:43 PM, Cor Bosman <[email protected]
> <mailto:[email protected]>> wrote:
>
>
> On Aug 31, 2013, at 2:00 PM, David Deutsch <[email protected]
> <mailto:[email protected]>> wrote:
>
>> Another possibly neat comparison:
>>
>> Original:
>>
>> https://github.com/roundcube/roundcubemail/blob/master/plugins/managesieve/lib/Roundcube/rcube_sieve_engine.php#L206
>> Cleanup:
>>
>> https://github.com/daviddeutsch/roundcubemail/blob/37167c5ce1c00cb4f42b7f59a9ff56b81b3cd874/plugins/managesieve/lib/Roundcube/rcube_sieve_engine.php#L219
>>
>> The code may be /slightly/ less DRY, but, I find, a lot more readable.
>
> Definitely more readable.
>
>>
>> I must also say that so far, I find very few yoda conditions! ;-)
>
> Find them you will.
>
> Cor
>
>
> _______________________________________________
> Roundcube Development discussion mailing list
> [email protected] <mailto:[email protected]>
> http://lists.roundcube.net/mailman/listinfo/dev
>
>
> _______________________________________________
> Roundcube Development discussion mailing list
> [email protected]
> http://lists.roundcube.net/mailman/listinfo/dev
_______________________________________________
Roundcube Development discussion mailing list
[email protected]
http://lists.roundcube.net/mailman/listinfo/dev
