Hi, I have uploaded the changes on codereview ( https://codereview.scilab.org/#/c/18895/). Do we have to upload the patch for the bug somewhere? Is there anything else I need to do for this bug? Also could you tell me where to find the SHA1 hash needed to make changes the to uploaded file. If I'm unable to reproduce some of the bugs on bugzilla, should I comment on them or write something?
On 16 Jan 2017 1:20 p.m., "Clément David" < [email protected]> wrote: > Hi Nikhil, > > Thanks for the patch, I have only one remark ; when fixing a bug, you > should indicate it in the > commit message ; take a look at `git log` for examples. > > For submitting the patch (using git), you could use the > codereview.scilab.org website using your > scilab account (mail and password). Instead of sending "pull requests" we > use gerrit to review > patches, please set it up accordingly to the wiki instructions. > > PS: in that case a non-regression tests is optional as this is only a GUI > improvement. > > Thanks, > > -- > Clement > > Le dimanche 15 janvier 2017 à 02:01 +0530, nikhil goel a écrit : > > Hi, > > > > Attached below is the patch for the bug #14911. > > > > The patch includes CHANGES.md file and the java file in which changes > were done. > > > > I was not able to attach the screenshots of the manual non_reg test due > to the 100kb constraint. > > It is still in process of being accepted. Please see the attached > screenshots in that mail. > > > > If any other changes have to be done or any other files have to be > edited, Please tell me. I was > > also wondering if it's possible for me to directly send pull requests. > > > > Thanks > > _______________________________________________ > > dev mailing list > > [email protected] > > http://lists.scilab.org/mailman/listinfo/dev > _______________________________________________ > dev mailing list > [email protected] > http://lists.scilab.org/mailman/listinfo/dev >
_______________________________________________ dev mailing list [email protected] http://lists.scilab.org/mailman/listinfo/dev
