Hello Wonguk, Yes using a specific name such as common_installer should be better, I'm going to update Pawel review to include this comment.
Thanks 2015-01-05 1:50 GMT+01:00 WonGuk Jeong <[email protected]>: > Dear Pawel, > > > > Thank you for guick answer. > > As far as I know, generally, we avoid to use too general namespace for > library in particular. > > You used "common" as top namespace for "common-installer" library. > > why don't you use a little bit specific name? (ex. common_installer?) > > > > Best regards, > > Wonguk > > > > ------- *Original Message* ------- > > *Sender* : Pawel Sikorski<[email protected]> Software > Engineer/SRPOL-Web Platform (PSD)/삼성전자 > > *Date* : 2015-01-02 11:39 (GMT+01:00) > > *Title* : RE: [Dev] [App Installer] namespace rule? > > > > Dear Wonguk, > > Thank you for the consideration. > > To be honest, it is one of the todo list item J. > > Here is the proposition: https://review.tizen.org/gerrit/#/c/33028/ > > Briefly, there will be such namespaces defined: > > · namespace common {} – this namespace includes all > app-installers definitions (Step, ContextInstaller, utils, AppInstaller) > > · namespace utils {} – this namespace includes all extra > definitions that are not directly related to app-installer framework and > are used within the project (eg. logging, “dirs” handling, design patterns > primitives (eg. singleton) etc) > > · namespace common/unzip {} – this is a namespace that includes > unzipping step and its additional definitions > > · namespace common/signature {} - this is a namespace that > includes signature step and its additional definitions > > · namespace common/copy {}, common/register {}, etc – these > namespaces are analogic to unzip or signature > > · namespace wgt {} - this is a namespace that includes > definitions specified for wgt type installation > > · namespace wgt/parse {} - this is a namespace that includes > parsing step specified for wgt type installation > > > > what do you think about that? > > Best Regards, > > Pawel Sikorski > > *From:* Dev [mailto:[email protected]] *On Behalf Of *??? > *Sent:* Friday, January 02, 2015 3:06 AM > *To:* [email protected] > *Subject:* [Dev] [App Installer] namespace rule? > > > > Dear folks, > > > > Does anybody know the namespace rule in app-installer? > > > > There is unlikely namespace rule at this moment. > > For instance, even in the common-installer library, step_signature uses > "common", > > but others(step_unzip, app-installer, context-installer, etc) in > comment-installer don't use such namespace. > > Moreover, the common-installer-signature uses namespace "signature".. > > > > I hope that app-installer maintainers clarify namespace rule before it's > getting complicated. > > > > Ciao, > > Wonguk > > > > > ━━━━━━━━━━━━━━━━━━━━━ > Jeong, Won guk > 차세대 Computing Lab. > S/W Center > > SAMSUNG ELECTRONICS CO.,LTD > > TEL : +82-31-279-7648 > Mobile : +82-10-9771-9501 > E-mail : [email protected] > ━━━━━━━━━━━━━━━━━━━━━ > > > > > _______________________________________________ > Dev mailing list > [email protected] > https://lists.tizen.org/listinfo/dev > > -- Baptiste DURAND Eurogiciel Vannes/FR
_______________________________________________ Dev mailing list [email protected] https://lists.tizen.org/listinfo/dev
