Sorry for the delayed response! Happy to hear that you have interest in contributing your work on this.
Personally, I think that the subtasks in LIVY-718 are not set in stone. That said, it is really hard to review a big bang PR and try to even get your head around everything that is happening let alone keep it in your head to understand how it works through all the flows. Perhaps there is a refactoring that you could do to break it into logical pieces that are more reviewable with a particular scope spelled out? You could then file different subtasks and resolve old ones as Won't FIx or the like (maybe better to just clone the top level and go from there)? You could also address more than one JIRA in a single PR where it makes sense and is still reviewable. I am about to start an inventory of open 0.8.0 release JIRAs and restart the discussion on its release. I think targeting this work for 0.9.0 still makes sense and would give you time to do this refactoring. Anyone else have thoughts on this? thank you! --larry On Tue, May 2, 2023 at 7:10 PM 严细浪 <xilang....@gmail.com> wrote: > Hi All, > > As mentioned before, we have implemented Livy Cluster in our own branch, > the design is the same with https://issues.apache.org/jira/browse/LIVY-718 > with several minor differences. > The problem here is LIVY-718 has many sub tasks, and in our own branch Livy > Cluster code is included in many feature PR and bug fixing PR, it will take > time to separate them to sub tasks of LIVY-718. > So I am asking if I can submit all code in one PR? The problem in this way > is there are lots of code changes, will add code review cost. What are your > thoughts? > > And in the original plan, Livy Cluster should be included in 0.9.0, I am > not sure when we can release 0.8.0 ? > > Thanks! >
