Github user ajbozarth commented on a diff in the pull request:
https://github.com/apache/incubator-livy/pull/114#discussion_r223522428
--- Diff:
thriftserver/server/src/main/scala/org/apache/livy/thriftserver/ui/ThriftUIServlet.scala
---
@@ -0,0 +1,84 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.livy.thriftserver.ui
+
+import java.text.SimpleDateFormat
+
+import scala.collection.JavaConverters._
+import scala.xml.Node
+
+import org.json4s.{DefaultFormats, Formats}
+import org.scalatra.json._
+
+import org.apache.livy.server.ui.BaseServlet
+import org.apache.livy.thriftserver.LivyThriftServer
+
+class ThriftUIServlet(val basePath: String) extends BaseServlet with
JacksonJsonSupport {
+
+ protected implicit val jsonFormats: Formats = DefaultFormats
+
+ private val df = new SimpleDateFormat("yyyy-MM-dd HH:mm:ss")
+
+ private case class ThriftSessionsPage(name: String = "JDBC Sessions")
extends Page {
+ override def getNavTabs: Seq[Node] = {
--- End diff --
@vanzin because of how I designed the original UI the tabs were actually
closer to a breadcrumb than tabs. With the addition of the Thrift server UI
this changes. So before the "tabs" were:
- Sessions Page: `Sessions`
- Session Page: `Sessions | Session #`
- Session Log Page: `Sessions | Session # | Log`
but now the thrift server "tab" is always visible when it's running, based
on this misunderstanding maybe we should update how the nav bar functions based
on this new addition
---
